Skip to content

Commit 5a73015

Browse files
QiushiWudavem330
authored andcommitted
net: sun: fix missing release regions in cas_init_one().
In cas_init_one(), "pdev" is requested by "pci_request_regions", but it was not released after a call of the function “pci_write_config_byte” failed. Thus replace the jump target “err_write_cacheline” by "err_out_free_res". Fixes: 1f26dac ("[NET]: Add Sun Cassini driver.") Signed-off-by: Qiushi Wu <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent bf655ba commit 5a73015

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/net/ethernet/sun/cassini.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4963,7 +4963,7 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
49634963
cas_cacheline_size)) {
49644964
dev_err(&pdev->dev, "Could not set PCI cache "
49654965
"line size\n");
4966-
goto err_write_cacheline;
4966+
goto err_out_free_res;
49674967
}
49684968
}
49694969
#endif
@@ -5136,7 +5136,6 @@ static int cas_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
51365136
err_out_free_res:
51375137
pci_release_regions(pdev);
51385138

5139-
err_write_cacheline:
51405139
/* Try to restore it in case the error occurred after we
51415140
* set it.
51425141
*/

0 commit comments

Comments
 (0)