vfs: use ERR_CAST for err-ptr tossing in lookup_instantiate_filp

koct9i · Al Viro · commit 5a9a43646cf7 · 2011-07-22T19:42:13.000-04:00
Replace unclear (struct dentry *) to (struct file *) typecast with ERR_CAST() macro.

Signed-off-by: Konstantin Khlebnikov &lt;khlebnikov@openvz.org&gt;
Signed-off-by: Al Viro &lt;viro@zeniv.linux.org.uk&gt;
diff --git a/fs/open.c b/fs/open.c
@@ -793,7 +793,7 @@ struct file *lookup_instantiate_filp(struct nameidata *nd, struct dentry *dentry
 	return nd->intent.open.file;
 out_err:
 	release_open_intent(nd);
-	nd->intent.open.file = (struct file *)dentry;
+	nd->intent.open.file = ERR_CAST(dentry);
 	goto out;
 }
 EXPORT_SYMBOL_GPL(lookup_instantiate_filp);

Original file line number	Diff line number	Diff line change
`@@ -793,7 +793,7 @@ struct file lookup_instantiate_filp(struct nameidata nd, struct dentry *dentry`
`793`	`793`	`return nd->intent.open.file;`
`794`	`794`	`out_err:`
`795`	`795`	`release_open_intent(nd);`
`796`		`- nd->intent.open.file = (struct file *)dentry;`
	`796`	`+ nd->intent.open.file = ERR_CAST(dentry);`
`797`	`797`	`goto out;`
`798`	`798`	`}`
`799`	`799`	`EXPORT_SYMBOL_GPL(lookup_instantiate_filp);`