Skip to content

Commit 5a9e347

Browse files
VMoolaakpm00
authored andcommitted
mm/swap: convert deactivate_page() to folio_deactivate()
Deactivate_page() has already been converted to use folios, this change converts it to take in a folio argument instead of calling page_folio(). It also renames the function folio_deactivate() to be more consistent with other folio functions. [[email protected]: fix left-over comments, per Yu Zhao] Link: https://lkml.kernel.org/r/[email protected] Signed-off-by: Vishal Moola (Oracle) <[email protected]> Reviewed-by: Matthew Wilcox (Oracle) <[email protected]> Reviewed-by: SeongJae Park <[email protected]> Signed-off-by: Andrew Morton <[email protected]>
1 parent f70da5e commit 5a9e347

File tree

6 files changed

+13
-15
lines changed

6 files changed

+13
-15
lines changed

include/linux/swap.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -401,7 +401,7 @@ extern void lru_add_drain(void);
401401
extern void lru_add_drain_cpu(int cpu);
402402
extern void lru_add_drain_cpu_zone(struct zone *zone);
403403
extern void lru_add_drain_all(void);
404-
extern void deactivate_page(struct page *page);
404+
void folio_deactivate(struct folio *folio);
405405
void folio_mark_lazyfree(struct folio *folio);
406406
extern void swap_setup(void);
407407

mm/damon/paddr.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ static inline unsigned long damon_pa_mark_accessed_or_deactivate(
297297
if (mark_accessed)
298298
folio_mark_accessed(folio);
299299
else
300-
deactivate_page(&folio->page);
300+
folio_deactivate(folio);
301301
folio_put(folio);
302302
applied += folio_nr_pages(folio);
303303
}

mm/madvise.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -416,7 +416,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
416416
list_add(&folio->lru, &folio_list);
417417
}
418418
} else
419-
deactivate_page(&folio->page);
419+
folio_deactivate(folio);
420420
huge_unlock:
421421
spin_unlock(ptl);
422422
if (pageout)
@@ -510,7 +510,7 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd,
510510
list_add(&folio->lru, &folio_list);
511511
}
512512
} else
513-
deactivate_page(&folio->page);
513+
folio_deactivate(folio);
514514
}
515515

516516
arch_leave_lazy_mmu_mode();

mm/page-writeback.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2846,11 +2846,11 @@ bool folio_mark_dirty(struct folio *folio)
28462846

28472847
if (likely(mapping)) {
28482848
/*
2849-
* readahead/lru_deactivate_page could remain
2849+
* readahead/folio_deactivate could remain
28502850
* PG_readahead/PG_reclaim due to race with folio_end_writeback
28512851
* About readahead, if the folio is written, the flags would be
28522852
* reset. So no problem.
2853-
* About lru_deactivate_page, if the folio is redirtied,
2853+
* About folio_deactivate, if the folio is redirtied,
28542854
* the flag will be reset. So no problem. but if the
28552855
* folio is used by readahead it will confuse readahead
28562856
* and make it restart the size rampup process. But it's

mm/swap.c

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -733,17 +733,15 @@ void deactivate_file_folio(struct folio *folio)
733733
}
734734

735735
/*
736-
* deactivate_page - deactivate a page
737-
* @page: page to deactivate
736+
* folio_deactivate - deactivate a folio
737+
* @folio: folio to deactivate
738738
*
739-
* deactivate_page() moves @page to the inactive list if @page was on the active
740-
* list and was not an unevictable page. This is done to accelerate the reclaim
741-
* of @page.
739+
* folio_deactivate() moves @folio to the inactive list if @folio was on the
740+
* active list and was not unevictable. This is done to accelerate the
741+
* reclaim of @folio.
742742
*/
743-
void deactivate_page(struct page *page)
743+
void folio_deactivate(struct folio *folio)
744744
{
745-
struct folio *folio = page_folio(page);
746-
747745
if (folio_test_lru(folio) && !folio_test_unevictable(folio) &&
748746
(folio_test_active(folio) || lru_gen_enabled())) {
749747
struct folio_batch *fbatch;

mm/vmscan.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1920,7 +1920,7 @@ static unsigned int shrink_folio_list(struct list_head *folio_list,
19201920
!test_bit(PGDAT_DIRTY, &pgdat->flags))) {
19211921
/*
19221922
* Immediately reclaim when written back.
1923-
* Similar in principle to deactivate_page()
1923+
* Similar in principle to folio_deactivate()
19241924
* except we already have the folio isolated
19251925
* and know it's dirty
19261926
*/

0 commit comments

Comments
 (0)