Skip to content

Commit 5b775eb

Browse files
Jan Engelhardtkaber
authored andcommitted
netfilter: xtables: remove old comments about reentrancy
Signed-off-by: Jan Engelhardt <[email protected]> Signed-off-by: Patrick McHardy <[email protected]>
1 parent cd58bcd commit 5b775eb

File tree

4 files changed

+0
-10
lines changed

4 files changed

+0
-10
lines changed

net/ipv4/netfilter/ip_tables.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,8 +434,6 @@ ipt_do_table(struct sk_buff *skb,
434434
continue;
435435
}
436436

437-
/* Targets which reenter must return
438-
abs. verdicts */
439437
tgpar.target = t->u.kernel.target;
440438
tgpar.targinfo = t->data;
441439

net/ipv4/netfilter/ipt_REJECT.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -139,9 +139,6 @@ reject_tg(struct sk_buff *skb, const struct xt_target_param *par)
139139
{
140140
const struct ipt_reject_info *reject = par->targinfo;
141141

142-
/* WARNING: This code causes reentry within iptables.
143-
This means that the iptables jump stack is now crap. We
144-
must return an absolute verdict. --RR */
145142
switch (reject->with) {
146143
case IPT_ICMP_NET_UNREACHABLE:
147144
send_unreach(skb, ICMP_NET_UNREACH);

net/ipv6/netfilter/ip6_tables.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -451,8 +451,6 @@ ip6t_do_table(struct sk_buff *skb,
451451
continue;
452452
}
453453

454-
/* Targets which reenter must return
455-
abs. verdicts */
456454
tgpar.target = t->u.kernel.target;
457455
tgpar.targinfo = t->data;
458456

net/ipv6/netfilter/ip6t_REJECT.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -179,9 +179,6 @@ reject_tg6(struct sk_buff *skb, const struct xt_target_param *par)
179179
struct net *net = dev_net((par->in != NULL) ? par->in : par->out);
180180

181181
pr_debug("%s: medium point\n", __func__);
182-
/* WARNING: This code causes reentry within ip6tables.
183-
This means that the ip6tables jump stack is now crap. We
184-
must return an absolute verdict. --RR */
185182
switch (reject->with) {
186183
case IP6T_ICMP6_NO_ROUTE:
187184
send_unreach(net, skb, ICMPV6_NOROUTE, par->hooknum);

0 commit comments

Comments
 (0)