Skip to content

Commit 5d7f77e

Browse files
philenotfoundgregkh
authored andcommitted
serial: imx: fix bogus dev_err
Only one of the two is really required, not both: * have_rtscts or * have_rtsgpio In imx_rs485_config() this is done correctly, so RS485 is working, just the error message is false. Signed-off-by: Phil Eichinger <[email protected]> Reviewed-by: Fabio Estevam <[email protected]> Fixes: b8f3bff ("serial: imx: Support common rs485 binding for RTS polarity" Acked-by: Uwe Kleine-König <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 7842055 commit 5d7f77e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/tty/serial/imx.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2093,7 +2093,7 @@ static int serial_imx_probe(struct platform_device *pdev)
20932093
uart_get_rs485_mode(&pdev->dev, &sport->port.rs485);
20942094

20952095
if (sport->port.rs485.flags & SER_RS485_ENABLED &&
2096-
(!sport->have_rtscts || !sport->have_rtsgpio))
2096+
(!sport->have_rtscts && !sport->have_rtsgpio))
20972097
dev_err(&pdev->dev, "no RTS control, disabling rs485\n");
20982098

20992099
imx_rs485_config(&sport->port, &sport->port.rs485);

0 commit comments

Comments
 (0)