Skip to content

Commit 5dbdf73

Browse files
Uwe Kleine-KönigLiam Girdwood
authored andcommitted
move wm8400-regulator's probe function to .devinit.text
A pointer to wm8400_regulator_probe is passed to the core via platform_driver_register and so the function must not disappear when the .init sections are discarded. Otherwise (if also having HOTPLUG=y) unbinding and binding a device to the driver via sysfs will result in an oops as does a device being registered late. An alternative to this patch is using platform_driver_probe instead of platform_driver_register plus removing the pointer to the probe function from the struct platform_driver. Signed-off-by: Uwe Kleine-König <[email protected]> Signed-off-by: Liam Girdwood <[email protected]>
1 parent 1de9e8e commit 5dbdf73

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/regulator/wm8400-regulator.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,7 @@ static struct regulator_desc regulators[] = {
289289
},
290290
};
291291

292-
static int __init wm8400_regulator_probe(struct platform_device *pdev)
292+
static int __devinit wm8400_regulator_probe(struct platform_device *pdev)
293293
{
294294
struct regulator_dev *rdev;
295295

0 commit comments

Comments
 (0)