Skip to content

Commit 5dd2020

Browse files
committed
Merge tag 'powerpc-6.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux
Pull powerpc fixes from Michael Ellerman: - Finish a refactor of pgprot_framebuffer() which dependend on some changes that were merged via the drm tree - Fix some kernel-doc warnings to quieten the bots Thanks to Nathan Lynch and Thomas Zimmermann. * tag 'powerpc-6.7-2' of git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux: powerpc/rtas: Fix ppc_rtas_rmo_buf_show() kernel-doc powerpc/pseries/rtas-work-area: Fix rtas_work_area_reserve_arena() kernel-doc powerpc/fb: Call internal __phys_mem_access_prot() in fbdev code powerpc: Remove file parameter from phys_mem_access_prot() powerpc/machdep: Remove trailing whitespaces
2 parents 1b907d0 + 644b602 commit 5dd2020

File tree

8 files changed

+24
-24
lines changed

8 files changed

+24
-24
lines changed

arch/powerpc/include/asm/fb.h

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,7 @@ static inline pgprot_t pgprot_framebuffer(pgprot_t prot,
88
unsigned long vm_start, unsigned long vm_end,
99
unsigned long offset)
1010
{
11-
/*
12-
* PowerPC's implementation of phys_mem_access_prot() does
13-
* not use the file argument. Set it to NULL in preparation
14-
* of later updates to the interface.
15-
*/
16-
return phys_mem_access_prot(NULL, PHYS_PFN(offset), vm_end - vm_start, prot);
11+
return __phys_mem_access_prot(PHYS_PFN(offset), vm_end - vm_start, prot);
1712
}
1813
#define pgprot_framebuffer pgprot_framebuffer
1914

arch/powerpc/include/asm/machdep.h

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
#include <linux/export.h>
1111

1212
struct pt_regs;
13-
struct pci_bus;
13+
struct pci_bus;
1414
struct device_node;
1515
struct iommu_table;
1616
struct rtc_time;
@@ -78,8 +78,8 @@ struct machdep_calls {
7878
unsigned char (*nvram_read_val)(int addr);
7979
void (*nvram_write_val)(int addr, unsigned char val);
8080
ssize_t (*nvram_write)(char *buf, size_t count, loff_t *index);
81-
ssize_t (*nvram_read)(char *buf, size_t count, loff_t *index);
82-
ssize_t (*nvram_size)(void);
81+
ssize_t (*nvram_read)(char *buf, size_t count, loff_t *index);
82+
ssize_t (*nvram_size)(void);
8383
void (*nvram_sync)(void);
8484

8585
/* Exception handlers */
@@ -102,12 +102,11 @@ struct machdep_calls {
102102
*/
103103
long (*feature_call)(unsigned int feature, ...);
104104

105-
/* Get legacy PCI/IDE interrupt mapping */
105+
/* Get legacy PCI/IDE interrupt mapping */
106106
int (*pci_get_legacy_ide_irq)(struct pci_dev *dev, int channel);
107-
107+
108108
/* Get access protection for /dev/mem */
109-
pgprot_t (*phys_mem_access_prot)(struct file *file,
110-
unsigned long pfn,
109+
pgprot_t (*phys_mem_access_prot)(unsigned long pfn,
111110
unsigned long size,
112111
pgprot_t vma_prot);
113112

arch/powerpc/include/asm/pci.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,7 @@ extern void of_scan_pci_bridge(struct pci_dev *dev);
105105
extern void of_scan_bus(struct device_node *node, struct pci_bus *bus);
106106
extern void of_rescan_bus(struct device_node *node, struct pci_bus *bus);
107107

108-
struct file;
109-
extern pgprot_t pci_phys_mem_access_prot(struct file *file,
110-
unsigned long pfn,
108+
extern pgprot_t pci_phys_mem_access_prot(unsigned long pfn,
111109
unsigned long size,
112110
pgprot_t prot);
113111

arch/powerpc/include/asm/pgtable.h

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,9 +120,15 @@ static inline void mark_initmem_nx(void) { }
120120
int ptep_set_access_flags(struct vm_area_struct *vma, unsigned long address,
121121
pte_t *ptep, pte_t entry, int dirty);
122122

123+
pgprot_t __phys_mem_access_prot(unsigned long pfn, unsigned long size,
124+
pgprot_t vma_prot);
125+
123126
struct file;
124-
pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
125-
unsigned long size, pgprot_t vma_prot);
127+
static inline pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
128+
unsigned long size, pgprot_t vma_prot)
129+
{
130+
return __phys_mem_access_prot(pfn, size, vma_prot);
131+
}
126132
#define __HAVE_PHYS_MEM_ACCESS_PROT
127133

128134
void __update_mmu_cache(struct vm_area_struct *vma, unsigned long address, pte_t *ptep);

arch/powerpc/kernel/pci-common.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -521,8 +521,7 @@ int pci_iobar_pfn(struct pci_dev *pdev, int bar, struct vm_area_struct *vma)
521521
* PCI device, it tries to find the PCI device first and calls the
522522
* above routine
523523
*/
524-
pgprot_t pci_phys_mem_access_prot(struct file *file,
525-
unsigned long pfn,
524+
pgprot_t pci_phys_mem_access_prot(unsigned long pfn,
526525
unsigned long size,
527526
pgprot_t prot)
528527
{

arch/powerpc/kernel/rtas-proc.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -752,6 +752,8 @@ static int ppc_rtas_tone_volume_show(struct seq_file *m, void *v)
752752

753753
/**
754754
* ppc_rtas_rmo_buf_show() - Describe RTAS-addressable region for user space.
755+
* @m: seq_file output target.
756+
* @v: Unused.
755757
*
756758
* Base + size description of a range of RTAS-addressable memory set
757759
* aside for user space to use as work area(s) for certain RTAS

arch/powerpc/mm/mem.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,18 +35,18 @@ unsigned long long memory_limit;
3535
unsigned long empty_zero_page[PAGE_SIZE / sizeof(unsigned long)] __page_aligned_bss;
3636
EXPORT_SYMBOL(empty_zero_page);
3737

38-
pgprot_t phys_mem_access_prot(struct file *file, unsigned long pfn,
39-
unsigned long size, pgprot_t vma_prot)
38+
pgprot_t __phys_mem_access_prot(unsigned long pfn, unsigned long size,
39+
pgprot_t vma_prot)
4040
{
4141
if (ppc_md.phys_mem_access_prot)
42-
return ppc_md.phys_mem_access_prot(file, pfn, size, vma_prot);
42+
return ppc_md.phys_mem_access_prot(pfn, size, vma_prot);
4343

4444
if (!page_is_ram(pfn))
4545
vma_prot = pgprot_noncached(vma_prot);
4646

4747
return vma_prot;
4848
}
49-
EXPORT_SYMBOL(phys_mem_access_prot);
49+
EXPORT_SYMBOL(__phys_mem_access_prot);
5050

5151
#ifdef CONFIG_MEMORY_HOTPLUG
5252
static DEFINE_MUTEX(linear_mapping_mutex);

arch/powerpc/platforms/pseries/rtas-work-area.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,6 +184,7 @@ machine_arch_initcall(pseries, rtas_work_area_allocator_init);
184184

185185
/**
186186
* rtas_work_area_reserve_arena() - Reserve memory suitable for RTAS work areas.
187+
* @limit: Upper limit for memblock allocation.
187188
*/
188189
void __init rtas_work_area_reserve_arena(const phys_addr_t limit)
189190
{

0 commit comments

Comments
 (0)