staging: bcm2835-audio: propagate PTR_ERR value instead of -EPERM

aishpant · gregkh · commit 5e00b25853ef · 2017-03-14T07:57:53.000+08:00
It is better to propagate PTR_ERR value instead of a hardcoded value
(-EPERM here)

Signed-off-by: Aishwarya Pant &lt;aishpant@gmail.com&gt;
Signed-off-by: Greg Kroah-Hartman &lt;gregkh@linuxfoundation.org&gt;
diff --git a/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c b/drivers/staging/vc04_services/bcm2835-audio/bcm2835-vchiq.c
@@ -436,7 +436,7 @@ static int bcm2835_audio_open_connection(struct bcm2835_alsa_stream *alsa_stream
 	if (IS_ERR(instance)) {
 		LOG_ERR("%s: failed to initialize audio service\n", __func__);
 
-		ret = -EPERM;
+		ret = PTR_ERR(instance);
 		goto err_free_mem;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -436,7 +436,7 @@ static int bcm2835_audio_open_connection(struct bcm2835_alsa_stream *alsa_stream`
`436`	`436`	`if (IS_ERR(instance)) {`
`437`	`437`	`LOG_ERR("%s: failed to initialize audio service\n", __func__);`
`438`	`438`
`439`		`- ret = -EPERM;`
	`439`	`+ ret = PTR_ERR(instance);`
`440`	`440`	`goto err_free_mem;`
`441`	`441`	`}`
`442`	`442`