Skip to content

Commit 5e8daf9

Browse files
dlsloanliu-song-6
authored andcommitted
md: Flush workqueue md_rdev_misc_wq in md_alloc()
A race condition still exists when removing and re-creating md devices in test cases. However, it is only seen on some setups. The race condition was tracked down to a reference still being held to the kobject by the rdev in the md_rdev_misc_wq which will be released in rdev_delayed_delete(). md_alloc() waits for previous deletions by waiting on the md_misc_wq, but the md_rdev_misc_wq may still be holding a reference to a recently removed device. To fix this, also flush the md_rdev_misc_wq in md_alloc(). Signed-off-by: David Sloan <[email protected]> [[email protected]: rewrote commit message] Signed-off-by: Logan Gunthorpe <[email protected]> Signed-off-by: Song Liu <[email protected]>
1 parent 265ad47 commit 5e8daf9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/md/md.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5620,6 +5620,7 @@ struct mddev *md_alloc(dev_t dev, char *name)
56205620
* removed (mddev_delayed_delete).
56215621
*/
56225622
flush_workqueue(md_misc_wq);
5623+
flush_workqueue(md_rdev_misc_wq);
56235624

56245625
mutex_lock(&disks_mutex);
56255626
mddev = mddev_alloc(dev);

0 commit comments

Comments
 (0)