Skip to content

Commit 5eb70db

Browse files
committed
netdev-genl: avoid empty messages in queue dump
Empty netlink responses from do() are not correct (as opposed to dump() where not dumping anything is perfectly fine). We should return an error if the target object does not exist, in this case if the netdev is down it has no queues. Fixes: 6b6171d ("netdev-genl: Add netlink framework functions for queue") Reported-by: [email protected] Reviewed-by: Eric Dumazet <[email protected]> Reviewed-by: Joe Damato <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 16f027c commit 5eb70db

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

net/core/netdev-genl.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,10 +430,10 @@ static int
430430
netdev_nl_queue_fill(struct sk_buff *rsp, struct net_device *netdev, u32 q_idx,
431431
u32 q_type, const struct genl_info *info)
432432
{
433-
int err = 0;
433+
int err;
434434

435435
if (!(netdev->flags & IFF_UP))
436-
return err;
436+
return -ENOENT;
437437

438438
err = netdev_nl_queue_validate(netdev, q_idx, q_type);
439439
if (err)

0 commit comments

Comments
 (0)