Skip to content

Commit 5f4019a

Browse files
julianwiedmanndavem330
authored andcommitted
s390/qeth: remove fake_broadcast attribute
Ever since commit 4a71df5 ("qeth: new qeth device driver") introduced this attribute, it can be read & written but has no actual effect. Signed-off-by: Julian Wiedmann <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 4bd27ee commit 5f4019a

File tree

2 files changed

+0
-36
lines changed

2 files changed

+0
-36
lines changed

drivers/s390/net/qeth_core.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -710,7 +710,6 @@ struct qeth_card_options {
710710
struct qeth_ipa_caps adp; /* Adapter parameters */
711711
struct qeth_sbp_info sbp; /* SETBRIDGEPORT options */
712712
struct qeth_vnicc_info vnicc; /* VNICC options */
713-
int fake_broadcast;
714713
enum qeth_discipline_id layer;
715714
enum qeth_ipa_isolation_modes isolation;
716715
enum qeth_ipa_isolation_modes prev_isolation;

drivers/s390/net/qeth_l3_sys.c

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -133,40 +133,6 @@ static ssize_t qeth_l3_dev_route6_store(struct device *dev,
133133
static DEVICE_ATTR(route6, 0644, qeth_l3_dev_route6_show,
134134
qeth_l3_dev_route6_store);
135135

136-
static ssize_t qeth_l3_dev_fake_broadcast_show(struct device *dev,
137-
struct device_attribute *attr, char *buf)
138-
{
139-
struct qeth_card *card = dev_get_drvdata(dev);
140-
141-
return sprintf(buf, "%i\n", card->options.fake_broadcast? 1:0);
142-
}
143-
144-
static ssize_t qeth_l3_dev_fake_broadcast_store(struct device *dev,
145-
struct device_attribute *attr, const char *buf, size_t count)
146-
{
147-
struct qeth_card *card = dev_get_drvdata(dev);
148-
char *tmp;
149-
int i, rc = 0;
150-
151-
mutex_lock(&card->conf_mutex);
152-
if (card->state != CARD_STATE_DOWN) {
153-
rc = -EPERM;
154-
goto out;
155-
}
156-
157-
i = simple_strtoul(buf, &tmp, 16);
158-
if ((i == 0) || (i == 1))
159-
card->options.fake_broadcast = i;
160-
else
161-
rc = -EINVAL;
162-
out:
163-
mutex_unlock(&card->conf_mutex);
164-
return rc ? rc : count;
165-
}
166-
167-
static DEVICE_ATTR(fake_broadcast, 0644, qeth_l3_dev_fake_broadcast_show,
168-
qeth_l3_dev_fake_broadcast_store);
169-
170136
static ssize_t qeth_l3_dev_sniffer_show(struct device *dev,
171137
struct device_attribute *attr, char *buf)
172138
{
@@ -305,7 +271,6 @@ static DEVICE_ATTR(hsuid, 0644, qeth_l3_dev_hsuid_show,
305271
static struct attribute *qeth_l3_device_attrs[] = {
306272
&dev_attr_route4.attr,
307273
&dev_attr_route6.attr,
308-
&dev_attr_fake_broadcast.attr,
309274
&dev_attr_sniffer.attr,
310275
&dev_attr_hsuid.attr,
311276
NULL,

0 commit comments

Comments
 (0)