NFSv4: Return delegations synchronously in evict_inode

trondmypd · trondmypd · commit 5fcdfacc01f3 · 2015-03-27T12:24:36.000-04:00
Kinglong Mee reports that asynchronous delegations are being killed
by the call to rpc_shutdown_client() when unmounting. This can lead
to state leakage on the server until the client lease expires.

Reported-by: Kinglong Mee &lt;kinglongmee@gmail.com&gt;
Signed-off-by: Trond Myklebust &lt;trond.myklebust@primarydata.com&gt;
diff --git a/fs/nfs/delegation.c b/fs/nfs/delegation.c
@@ -514,7 +514,7 @@ void nfs_inode_return_delegation_noreclaim(struct inode *inode)
 
 	delegation = nfs_inode_detach_delegation(inode);
 	if (delegation != NULL)
-		nfs_do_return_delegation(inode, delegation, 0);
+		nfs_do_return_delegation(inode, delegation, 1);
 }
 
 /**

Original file line number	Diff line number	Diff line change
`@@ -514,7 +514,7 @@ void nfs_inode_return_delegation_noreclaim(struct inode *inode)`
`514`	`514`
`515`	`515`	`delegation = nfs_inode_detach_delegation(inode);`
`516`	`516`	`if (delegation != NULL)`
`517`		`- nfs_do_return_delegation(inode, delegation, 0);`
	`517`	`+ nfs_do_return_delegation(inode, delegation, 1);`
`518`	`518`	`}`
`519`	`519`
`520`	`520`	`/**`