Skip to content

Commit 60c1f89

Browse files
committed
Merge tag 'dma-mapping-4.19-2' of git://git.infradead.org/users/hch/dma-mapping
Pull dma-mapping fixes from Christoph Hellwig: "A few fixes for the fallout of being a little more pedantic about dma masks" * tag 'dma-mapping-4.19-2' of git://git.infradead.org/users/hch/dma-mapping: of/platform: initialise AMBA default DMA masks sparc: set a default 32-bit dma mask for OF devices kernel/dma/direct: take DMA offset into account in dma_direct_supported
2 parents 5736184 + 8c89ef7 commit 60c1f89

File tree

4 files changed

+13
-2
lines changed

4 files changed

+13
-2
lines changed

arch/sparc/kernel/of_device_32.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
#include <linux/irq.h>
1010
#include <linux/of_device.h>
1111
#include <linux/of_platform.h>
12+
#include <linux/dma-mapping.h>
1213
#include <asm/leon.h>
1314
#include <asm/leon_amba.h>
1415

@@ -381,6 +382,9 @@ static struct platform_device * __init scan_one_device(struct device_node *dp,
381382
else
382383
dev_set_name(&op->dev, "%08x", dp->phandle);
383384

385+
op->dev.coherent_dma_mask = DMA_BIT_MASK(32);
386+
op->dev.dma_mask = &op->dev.coherent_dma_mask;
387+
384388
if (of_device_register(op)) {
385389
printk("%s: Could not register of device.\n",
386390
dp->full_name);

arch/sparc/kernel/of_device_64.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
#include <linux/string.h>
33
#include <linux/kernel.h>
44
#include <linux/of.h>
5+
#include <linux/dma-mapping.h>
56
#include <linux/init.h>
67
#include <linux/export.h>
78
#include <linux/mod_devicetable.h>
@@ -675,6 +676,8 @@ static struct platform_device * __init scan_one_device(struct device_node *dp,
675676
dev_set_name(&op->dev, "root");
676677
else
677678
dev_set_name(&op->dev, "%08x", dp->phandle);
679+
op->dev.coherent_dma_mask = DMA_BIT_MASK(32);
680+
op->dev.dma_mask = &op->dev.coherent_dma_mask;
678681

679682
if (of_device_register(op)) {
680683
printk("%s: Could not register of device.\n",

drivers/of/platform.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -241,6 +241,10 @@ static struct amba_device *of_amba_device_create(struct device_node *node,
241241
if (!dev)
242242
goto err_clear_flag;
243243

244+
/* AMBA devices only support a single DMA mask */
245+
dev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
246+
dev->dev.dma_mask = &dev->dev.coherent_dma_mask;
247+
244248
/* setup generic device info */
245249
dev->dev.of_node = of_node_get(node);
246250
dev->dev.fwnode = &node->fwnode;

kernel/dma/direct.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ int dma_direct_map_sg(struct device *dev, struct scatterlist *sgl, int nents,
168168
int dma_direct_supported(struct device *dev, u64 mask)
169169
{
170170
#ifdef CONFIG_ZONE_DMA
171-
if (mask < DMA_BIT_MASK(ARCH_ZONE_DMA_BITS))
171+
if (mask < phys_to_dma(dev, DMA_BIT_MASK(ARCH_ZONE_DMA_BITS)))
172172
return 0;
173173
#else
174174
/*
@@ -177,7 +177,7 @@ int dma_direct_supported(struct device *dev, u64 mask)
177177
* memory, or by providing a ZONE_DMA32. If neither is the case, the
178178
* architecture needs to use an IOMMU instead of the direct mapping.
179179
*/
180-
if (mask < DMA_BIT_MASK(32))
180+
if (mask < phys_to_dma(dev, DMA_BIT_MASK(32)))
181181
return 0;
182182
#endif
183183
/*

0 commit comments

Comments
 (0)