Skip to content

Commit 618fd1e

Browse files
gbhat-marvellKalle Valo
authored andcommitted
mwifiex: avoid exporting mwifiex_send_cmd
This is a follow-up patch for commit 21c5c83 ("mwifiex: support sysfs initiated device coredump"). Let us avoid exporting mwifiex_send_cmd and instead use a utility function mwifiex_fw_dump_event to achive the work. Signed-off-by: Ganapathi Bhat <[email protected]> Signed-off-by: Kalle Valo <[email protected]>
1 parent a53e8f3 commit 618fd1e

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

drivers/net/wireless/marvell/mwifiex/cmdevt.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -674,7 +674,6 @@ int mwifiex_send_cmd(struct mwifiex_private *priv, u16 cmd_no,
674674

675675
return ret;
676676
}
677-
EXPORT_SYMBOL_GPL(mwifiex_send_cmd);
678677

679678
/*
680679
* This function queues a command to the command pending queue.

drivers/net/wireless/marvell/mwifiex/main.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1691,6 +1691,7 @@ void mwifiex_drv_info_dump(struct mwifiex_adapter *adapter);
16911691
void mwifiex_prepare_fw_dump_info(struct mwifiex_adapter *adapter);
16921692
void mwifiex_upload_device_dump(struct mwifiex_adapter *adapter);
16931693
void *mwifiex_alloc_dma_align_buf(int rx_len, gfp_t flags);
1694+
void mwifiex_fw_dump_event(struct mwifiex_private *priv);
16941695
void mwifiex_queue_main_work(struct mwifiex_adapter *adapter);
16951696
int mwifiex_get_wakeup_reason(struct mwifiex_private *priv, u16 action,
16961697
int cmd_type,

drivers/net/wireless/marvell/mwifiex/usb.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -658,9 +658,8 @@ static void mwifiex_usb_coredump(struct device *dev)
658658
struct usb_interface *intf = to_usb_interface(dev);
659659
struct usb_card_rec *card = usb_get_intfdata(intf);
660660

661-
mwifiex_send_cmd(mwifiex_get_priv(card->adapter, MWIFIEX_BSS_ROLE_ANY),
662-
HostCmd_CMD_FW_DUMP_EVENT, HostCmd_ACT_GEN_SET, 0,
663-
NULL, true);
661+
mwifiex_fw_dump_event(mwifiex_get_priv(card->adapter,
662+
MWIFIEX_BSS_ROLE_ANY));
664663
}
665664

666665
static struct usb_driver mwifiex_usb_driver = {

drivers/net/wireless/marvell/mwifiex/util.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -757,3 +757,10 @@ void *mwifiex_alloc_dma_align_buf(int rx_len, gfp_t flags)
757757
return skb;
758758
}
759759
EXPORT_SYMBOL_GPL(mwifiex_alloc_dma_align_buf);
760+
761+
void mwifiex_fw_dump_event(struct mwifiex_private *priv)
762+
{
763+
mwifiex_send_cmd(priv, HostCmd_CMD_FW_DUMP_EVENT, HostCmd_ACT_GEN_SET,
764+
0, NULL, true);
765+
}
766+
EXPORT_SYMBOL_GPL(mwifiex_fw_dump_event);

0 commit comments

Comments
 (0)