Skip to content

Commit 61e0065

Browse files
David HerrmannJiri Kosina
authored andcommitted
Input: introduce BTN/ABS bits for drums and guitars
There are a bunch of guitar and drums devices out there that all report similar data. To avoid reporting this as BTN_MISC or ABS_MISC, we allocate some proper namespace for them. Note that most of these devices are toys and we cannot report any sophisticated physics via this API. I did some google-images research and tried to provide definitions that work with all common devices. That's why I went with 4 toms, 4 cymbals, one bass, one hi-hat. I haven't seen other drums and I doubt that we need any additions to that. Anyway, the naming-scheme is intentionally done in an extensible way. For guitars, we support 5 frets (normally aligned vertically, compared to the real horizontal layouts), a single strum-bar with up/down directions, an optional fret-board and a whammy-bar. Most of the devices provide pressure values so I went with ABS_* bits. If we ever support devices which only provide digital input, we have to decide whether to emulate pressure data or add additional BTN_* bits. If someone is not familiar with these devices, here are two pictures which provide almost all introduced interfaces (or try the given keywords with a google-image search): Guitar: ("guitar hero world tour guitar") http://images1.wikia.nocookie.net/__cb20120911023442/applezone/es/images/f/f9/Wii_Guitar.jpg Drums: ("guitar hero drums") http://oyster.ignimgs.com/franchises/images/03/55/35526_band-hero-drum-set-hands-on-20090929040735768.jpg Signed-off-by: David Herrmann <[email protected]> Acked-by: Dmitry Torokhov <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent a6be856 commit 61e0065

File tree

2 files changed

+24
-3
lines changed

2 files changed

+24
-3
lines changed

include/linux/mod_devicetable.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -277,7 +277,7 @@ struct pcmcia_device_id {
277277
#define INPUT_DEVICE_ID_KEY_MIN_INTERESTING 0x71
278278
#define INPUT_DEVICE_ID_KEY_MAX 0x2ff
279279
#define INPUT_DEVICE_ID_REL_MAX 0x0f
280-
#define INPUT_DEVICE_ID_ABS_MAX 0x3f
280+
#define INPUT_DEVICE_ID_ABS_MAX 0x4f
281281
#define INPUT_DEVICE_ID_MSC_MAX 0x07
282282
#define INPUT_DEVICE_ID_LED_MAX 0x0f
283283
#define INPUT_DEVICE_ID_SND_MAX 0x07

include/uapi/linux/input.h

Lines changed: 23 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -716,6 +716,14 @@ struct input_keymap_entry {
716716
#define BTN_DPAD_LEFT 0x222
717717
#define BTN_DPAD_RIGHT 0x223
718718

719+
#define BTN_FRET_FAR_UP 0x224
720+
#define BTN_FRET_UP 0x225
721+
#define BTN_FRET_MID 0x226
722+
#define BTN_FRET_LOW 0x227
723+
#define BTN_FRET_FAR_LOW 0x228
724+
#define BTN_STRUM_BAR_UP 0x229
725+
#define BTN_STRUM_BAR_DOWN 0x22a
726+
719727
#define BTN_TRIGGER_HAPPY 0x2c0
720728
#define BTN_TRIGGER_HAPPY1 0x2c0
721729
#define BTN_TRIGGER_HAPPY2 0x2c1
@@ -829,8 +837,21 @@ struct input_keymap_entry {
829837
#define ABS_MT_TOOL_X 0x3c /* Center X tool position */
830838
#define ABS_MT_TOOL_Y 0x3d /* Center Y tool position */
831839

832-
833-
#define ABS_MAX 0x3f
840+
/* Drums and guitars (mostly toys) */
841+
#define ABS_TOM_FAR_LEFT 0x40
842+
#define ABS_TOM_LEFT 0x41
843+
#define ABS_TOM_RIGHT 0x42
844+
#define ABS_TOM_FAR_RIGHT 0x43
845+
#define ABS_CYMBAL_FAR_LEFT 0x44
846+
#define ABS_CYMBAL_LEFT 0x45
847+
#define ABS_CYMBAL_RIGHT 0x46
848+
#define ABS_CYMBAL_FAR_RIGHT 0x47
849+
#define ABS_BASS 0x48
850+
#define ABS_HI_HAT 0x49
851+
#define ABS_FRET_BOARD 0x4a /* Guitar fret board, vertical pos */
852+
#define ABS_WHAMMY_BAR 0x4b /* Guitar whammy bar (or vibrato) */
853+
854+
#define ABS_MAX 0x4f
834855
#define ABS_CNT (ABS_MAX+1)
835856

836857
/*

0 commit comments

Comments
 (0)