Skip to content

Commit 62765d3

Browse files
XidianGeneraldavem330
authored andcommitted
net: wan: fix error return code of uhdlc_init()
When priv->rx_skbuff or priv->tx_skbuff is NULL, no error return code of uhdlc_init() is assigned. To fix this bug, ret is assigned with -ENOMEM in these cases. Reported-by: TOTE Robot <[email protected]> Signed-off-by: Jia-Ju Bai <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 143c253 commit 62765d3

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

drivers/net/wan/fsl_ucc_hdlc.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -204,14 +204,18 @@ static int uhdlc_init(struct ucc_hdlc_private *priv)
204204
priv->rx_skbuff = kcalloc(priv->rx_ring_size,
205205
sizeof(*priv->rx_skbuff),
206206
GFP_KERNEL);
207-
if (!priv->rx_skbuff)
207+
if (!priv->rx_skbuff) {
208+
ret = -ENOMEM;
208209
goto free_ucc_pram;
210+
}
209211

210212
priv->tx_skbuff = kcalloc(priv->tx_ring_size,
211213
sizeof(*priv->tx_skbuff),
212214
GFP_KERNEL);
213-
if (!priv->tx_skbuff)
215+
if (!priv->tx_skbuff) {
216+
ret = -ENOMEM;
214217
goto free_rx_skbuff;
218+
}
215219

216220
priv->skb_curtx = 0;
217221
priv->skb_dirtytx = 0;

0 commit comments

Comments
 (0)