Skip to content

Commit 62794fc

Browse files
congwangJakub Kicinski
authored andcommitted
net_sched: add max len check for TCA_KIND
The TCA_KIND attribute is of NLA_STRING which does not check the NUL char. KMSAN reported an uninit-value of TCA_KIND which is likely caused by the lack of NUL. Change it to NLA_NUL_STRING and add a max len too. Fixes: 8b4c3cd ("net: sched: Add policy validation for tc attributes") Reported-and-tested-by: [email protected] Cc: Jamal Hadi Salim <[email protected]> Signed-off-by: Cong Wang <[email protected]> Reviewed-by: David Ahern <[email protected]> Acked-by: Jiri Pirko <[email protected]> Signed-off-by: Jakub Kicinski <[email protected]>
1 parent b0e1ee4 commit 62794fc

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/sched/sch_api.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1390,7 +1390,8 @@ check_loop_fn(struct Qdisc *q, unsigned long cl, struct qdisc_walker *w)
13901390
}
13911391

13921392
const struct nla_policy rtm_tca_policy[TCA_MAX + 1] = {
1393-
[TCA_KIND] = { .type = NLA_STRING },
1393+
[TCA_KIND] = { .type = NLA_NUL_STRING,
1394+
.len = IFNAMSIZ - 1 },
13941395
[TCA_RATE] = { .type = NLA_BINARY,
13951396
.len = sizeof(struct tc_estimator) },
13961397
[TCA_STAB] = { .type = NLA_NESTED },

0 commit comments

Comments
 (0)