Skip to content

Commit 6297728

Browse files
stbuehleraxboe
authored andcommitted
io_uring: remove unnecessary barrier after unsetting IORING_SQ_NEED_WAKEUP
There is no operation to order with afterwards, and removing the flag is not critical in any way. There will always be a "race condition" where the application will trigger IORING_ENTER_SQ_WAKEUP when it isn't actually needed. Signed-off-by: Stefan Bühler <[email protected]> Signed-off-by: Jens Axboe <[email protected]>
1 parent b841f19 commit 6297728

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

fs/io_uring.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1969,13 +1969,11 @@ static int io_sq_thread(void *data)
19691969
finish_wait(&ctx->sqo_wait, &wait);
19701970

19711971
ctx->sq_ring->flags &= ~IORING_SQ_NEED_WAKEUP;
1972-
smp_wmb();
19731972
continue;
19741973
}
19751974
finish_wait(&ctx->sqo_wait, &wait);
19761975

19771976
ctx->sq_ring->flags &= ~IORING_SQ_NEED_WAKEUP;
1978-
smp_wmb();
19791977
}
19801978

19811979
i = 0;

0 commit comments

Comments
 (0)