Skip to content

Commit 646ebd4

Browse files
rleondledford
authored andcommitted
RDMA: Don't reference kernel private header from UAPI header
Remove references to private kernel header and defines from exported ib_user_verb.h file. The code snippet below is used to reproduce the issue: #include <stdio.h> #include <rdma/ib_user_verb.h> int main(void) { printf("IB_USER_VERBS_ABI_VERSION = %d\n", IB_USER_VERBS_ABI_VERSION); return 0; } It fails during compilation phase with an error: ➜ /tmp gcc main.c main.c:2:31: fatal error: rdma/ib_user_verb.h: No such file or directory #include <rdma/ib_user_verb.h> ^ compilation terminated. Fixes: 189aba9 ("IB/uverbs: Extend modify_qp and support packet pacing") CC: Bodong Wang <[email protected]> CC: Matan Barak <[email protected]> CC: Christoph Hellwig <[email protected]> Tested-by: Slava Shwartsman <[email protected]> Signed-off-by: Leon Romanovsky <[email protected]> Signed-off-by: Doug Ledford <[email protected]>
1 parent 647bf3d commit 646ebd4

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

include/uapi/rdma/ib_user_verbs.h

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@
3737
#define IB_USER_VERBS_H
3838

3939
#include <linux/types.h>
40-
#include <rdma/ib_verbs.h>
4140

4241
/*
4342
* Increment this value if any changes that break userspace ABI
@@ -548,11 +547,17 @@ enum {
548547
};
549548

550549
enum {
551-
IB_USER_LEGACY_LAST_QP_ATTR_MASK = IB_QP_DEST_QPN
550+
/*
551+
* This value is equal to IB_QP_DEST_QPN.
552+
*/
553+
IB_USER_LEGACY_LAST_QP_ATTR_MASK = 1ULL << 20,
552554
};
553555

554556
enum {
555-
IB_USER_LAST_QP_ATTR_MASK = IB_QP_RATE_LIMIT
557+
/*
558+
* This value is equal to IB_QP_RATE_LIMIT.
559+
*/
560+
IB_USER_LAST_QP_ATTR_MASK = 1ULL << 25,
556561
};
557562

558563
struct ib_uverbs_ex_create_qp {

0 commit comments

Comments
 (0)