Skip to content

Commit 648695c

Browse files
elfringkleikamp
authored andcommitted
jfs: Deletion of an unnecessary check before the function call "unload_nls"
The unload_nls() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring <[email protected]> Signed-off-by: Dave Kleikamp <[email protected]>
1 parent e1f1fe7 commit 648695c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

fs/jfs/super.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -619,8 +619,7 @@ static int jfs_fill_super(struct super_block *sb, void *data, int silent)
619619
iput(sbi->direct_inode);
620620
sbi->direct_inode = NULL;
621621
out_unload:
622-
if (sbi->nls_tab)
623-
unload_nls(sbi->nls_tab);
622+
unload_nls(sbi->nls_tab);
624623
out_kfree:
625624
kfree(sbi);
626625
return ret;

0 commit comments

Comments
 (0)