Skip to content

Commit 64a3727

Browse files
Yang Lidavem330
authored andcommitted
team: Remove NULL check before dev_{put, hold}
The call netdev_{put, hold} of dev_{put, hold} will check NULL, so there is no need to check before using dev_{put, hold}, remove it to silence the warning: ./drivers/net/team/team.c:2325:3-10: WARNING: NULL check before dev_{put, hold} functions is not needed. Reported-by: Abaci Robot <[email protected]> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5991 Signed-off-by: Yang Li <[email protected]> Reviewed-by: Simon Horman <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 88efedf commit 64a3727

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/net/team/team.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2321,8 +2321,7 @@ static struct team *team_nl_team_get(struct genl_info *info)
23212321
ifindex = nla_get_u32(info->attrs[TEAM_ATTR_TEAM_IFINDEX]);
23222322
dev = dev_get_by_index(net, ifindex);
23232323
if (!dev || dev->netdev_ops != &team_netdev_ops) {
2324-
if (dev)
2325-
dev_put(dev);
2324+
dev_put(dev);
23262325
return NULL;
23272326
}
23282327

0 commit comments

Comments
 (0)