Skip to content

Commit 6575f35

Browse files
committed
Merge branch 'sh_eth-fallback-compat-strings'
Simon Horman says: ==================== net: sh_eth: add R-Car Gen[12] fallback compatibility strings Add fallback compatibility strings for R-Car Gen 1 and 2. In the case of Renesas R-Car hardware we know that there are generations of SoCs, f.e. Gen 1 and 2. But beyond that its not clear what the relationship between IP blocks might be. For example, I believe that r8a7790 is older than r8a7791 but that doesn't imply that the latter is a descendant of the former or vice versa. We can, however, by examining the documentation and behaviour of the hardware at run-time observe that the current driver implementation appears to be compatible with the IP blocks on SoCs within a given generation. For the above reasons and convenience when enabling new SoCs a per-generation fallback compatibility string scheme is being adopted for drivers for Renesas SoCs. Changes since v1: * Correct typos in changelogs * Consistently use tabs for indentation in bindings document * Enhance readability of description of bindings usage ==================== Signed-off-by: David S. Miller <[email protected]>
2 parents 7a0947e + b4804e0 commit 6575f35

File tree

2 files changed

+29
-17
lines changed

2 files changed

+29
-17
lines changed

Documentation/devicetree/bindings/net/sh_eth.txt

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@ This file provides information on what the device node for the SH EtherMAC
44
interface contains.
55

66
Required properties:
7-
- compatible: "renesas,gether-r8a7740" if the device is a part of R8A7740 SoC.
7+
- compatible: Must contain one or more of the following:
8+
"renesas,gether-r8a7740" if the device is a part of R8A7740 SoC.
89
"renesas,ether-r8a7743" if the device is a part of R8A7743 SoC.
910
"renesas,ether-r8a7745" if the device is a part of R8A7745 SoC.
1011
"renesas,ether-r8a7778" if the device is a part of R8A7778 SoC.
@@ -14,6 +15,14 @@ Required properties:
1415
"renesas,ether-r8a7793" if the device is a part of R8A7793 SoC.
1516
"renesas,ether-r8a7794" if the device is a part of R8A7794 SoC.
1617
"renesas,ether-r7s72100" if the device is a part of R7S72100 SoC.
18+
"renesas,rcar-gen1-ether" for a generic R-Car Gen1 device.
19+
"renesas,rcar-gen2-ether" for a generic R-Car Gen2 or RZ/G1
20+
device.
21+
22+
When compatible with the generic version, nodes must list
23+
the SoC-specific version corresponding to the platform
24+
first followed by the generic version.
25+
1726
- reg: offset and length of (1) the E-DMAC/feLic register block (required),
1827
(2) the TSU register block (optional).
1928
- interrupts: interrupt specifier for the sole interrupt.
@@ -36,7 +45,8 @@ Optional properties:
3645
Example (Lager board):
3746

3847
ethernet@ee700000 {
39-
compatible = "renesas,ether-r8a7790";
48+
compatible = "renesas,ether-r8a7790",
49+
"renesas,rcar-gen2-ether";
4050
reg = <0 0xee700000 0 0x400>;
4151
interrupt-parent = <&gic>;
4252
interrupts = <0 162 IRQ_TYPE_LEVEL_HIGH>;

drivers/net/ethernet/renesas/sh_eth.c

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -594,7 +594,7 @@ static struct sh_eth_cpu_data r8a7740_data = {
594594
};
595595

596596
/* There is CPU dependent code */
597-
static void sh_eth_set_rate_r8a777x(struct net_device *ndev)
597+
static void sh_eth_set_rate_rcar(struct net_device *ndev)
598598
{
599599
struct sh_eth_private *mdp = netdev_priv(ndev);
600600

@@ -608,10 +608,10 @@ static void sh_eth_set_rate_r8a777x(struct net_device *ndev)
608608
}
609609
}
610610

611-
/* R8A7778/9 */
612-
static struct sh_eth_cpu_data r8a777x_data = {
611+
/* R-Car Gen1 */
612+
static struct sh_eth_cpu_data rcar_gen1_data = {
613613
.set_duplex = sh_eth_set_duplex,
614-
.set_rate = sh_eth_set_rate_r8a777x,
614+
.set_rate = sh_eth_set_rate_rcar,
615615

616616
.register_type = SH_ETH_REG_FAST_RCAR,
617617

@@ -635,10 +635,10 @@ static struct sh_eth_cpu_data r8a777x_data = {
635635
.hw_swap = 1,
636636
};
637637

638-
/* R8A7790/1 */
639-
static struct sh_eth_cpu_data r8a779x_data = {
638+
/* R-Car Gen2 and RZ/G1 */
639+
static struct sh_eth_cpu_data rcar_gen2_data = {
640640
.set_duplex = sh_eth_set_duplex,
641-
.set_rate = sh_eth_set_rate_r8a777x,
641+
.set_rate = sh_eth_set_rate_rcar,
642642

643643
.register_type = SH_ETH_REG_FAST_RCAR,
644644

@@ -3086,15 +3086,17 @@ static struct sh_eth_plat_data *sh_eth_parse_dt(struct device *dev)
30863086

30873087
static const struct of_device_id sh_eth_match_table[] = {
30883088
{ .compatible = "renesas,gether-r8a7740", .data = &r8a7740_data },
3089-
{ .compatible = "renesas,ether-r8a7743", .data = &r8a779x_data },
3090-
{ .compatible = "renesas,ether-r8a7745", .data = &r8a779x_data },
3091-
{ .compatible = "renesas,ether-r8a7778", .data = &r8a777x_data },
3092-
{ .compatible = "renesas,ether-r8a7779", .data = &r8a777x_data },
3093-
{ .compatible = "renesas,ether-r8a7790", .data = &r8a779x_data },
3094-
{ .compatible = "renesas,ether-r8a7791", .data = &r8a779x_data },
3095-
{ .compatible = "renesas,ether-r8a7793", .data = &r8a779x_data },
3096-
{ .compatible = "renesas,ether-r8a7794", .data = &r8a779x_data },
3089+
{ .compatible = "renesas,ether-r8a7743", .data = &rcar_gen2_data },
3090+
{ .compatible = "renesas,ether-r8a7745", .data = &rcar_gen2_data },
3091+
{ .compatible = "renesas,ether-r8a7778", .data = &rcar_gen1_data },
3092+
{ .compatible = "renesas,ether-r8a7779", .data = &rcar_gen1_data },
3093+
{ .compatible = "renesas,ether-r8a7790", .data = &rcar_gen2_data },
3094+
{ .compatible = "renesas,ether-r8a7791", .data = &rcar_gen2_data },
3095+
{ .compatible = "renesas,ether-r8a7793", .data = &rcar_gen2_data },
3096+
{ .compatible = "renesas,ether-r8a7794", .data = &rcar_gen2_data },
30973097
{ .compatible = "renesas,ether-r7s72100", .data = &r7s72100_data },
3098+
{ .compatible = "renesas,rcar-gen1-ether", .data = &rcar_gen1_data },
3099+
{ .compatible = "renesas,rcar-gen2-ether", .data = &rcar_gen2_data },
30983100
{ }
30993101
};
31003102
MODULE_DEVICE_TABLE(of, sh_eth_match_table);

0 commit comments

Comments
 (0)