Skip to content

Commit 65a29da

Browse files
gobenjiJeff Kirsher
authored andcommitted
e1000e: Fix wrong comment related to link detection
Reading e1000e_check_for_copper_link() shows that get_link_status is set to false after link has been detected. Therefore, it stays TRUE until then. Signed-off-by: Benjamin Poirier <[email protected]> Tested-by: Aaron Brown <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent c4c40e5 commit 65a29da

File tree

1 file changed

+2
-2
lines changed
  • drivers/net/ethernet/intel/e1000e

1 file changed

+2
-2
lines changed

drivers/net/ethernet/intel/e1000e/netdev.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5074,7 +5074,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)
50745074

50755075
/* get_link_status is set on LSC (link status) interrupt or
50765076
* Rx sequence error interrupt. get_link_status will stay
5077-
* false until the check_for_link establishes link
5077+
* true until the check_for_link establishes link
50785078
* for copper adapters ONLY
50795079
*/
50805080
switch (hw->phy.media_type) {
@@ -5092,7 +5092,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)
50925092
break;
50935093
case e1000_media_type_internal_serdes:
50945094
ret_val = hw->mac.ops.check_for_link(hw);
5095-
link_active = adapter->hw.mac.serdes_has_link;
5095+
link_active = hw->mac.serdes_has_link;
50965096
break;
50975097
default:
50985098
case e1000_media_type_unknown:

0 commit comments

Comments
 (0)