Skip to content

Commit 65c6ee9

Browse files
Dan Carpenterjmberg-intel
authored andcommitted
wifi: iwlwifi: uninitialized variable in iwl_acpi_get_ppag_table()
This is an error path and Smatch complains that "tbl_rev" is uninitialized on this path. All the other functions follow this same patter where they set the error code and goto out_free so that's probably what was intended here as well. Fixes: e8e10a3 ("iwlwifi: acpi: move ppag code from mvm to fw/acpi") Signed-off-by: Dan Carpenter <[email protected]> Link: https://msgid.link/[email protected] Signed-off-by: Johannes Berg <[email protected]>
1 parent c6ebb5b commit 65c6ee9

File tree

1 file changed

+3
-0
lines changed
  • drivers/net/wireless/intel/iwlwifi/fw

1 file changed

+3
-0
lines changed

drivers/net/wireless/intel/iwlwifi/fw/acpi.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1116,6 +1116,9 @@ int iwl_acpi_get_ppag_table(struct iwl_fw_runtime *fwrt)
11161116
goto read_table;
11171117
}
11181118

1119+
ret = PTR_ERR(wifi_pkg);
1120+
goto out_free;
1121+
11191122
read_table:
11201123
fwrt->ppag_ver = tbl_rev;
11211124
flags = &wifi_pkg->package.elements[1];

0 commit comments

Comments
 (0)