Skip to content

Commit 66072c2

Browse files
Tetsuo Handatorvalds
authored andcommitted
hfsplus: stop workqueue when fill_super() failed
syzbot is reporting ODEBUG messages at hfsplus_fill_super() [1]. This is because hfsplus_fill_super() forgot to call cancel_delayed_work_sync(). As far as I can see, it is hfsplus_mark_mdb_dirty() from hfsplus_new_inode() in hfsplus_fill_super() that calls queue_delayed_work(). Therefore, I assume that hfsplus_new_inode() does not fail if queue_delayed_work() was called, and the out_put_hidden_dir label is the appropriate location to call cancel_delayed_work_sync(). [1] https://syzkaller.appspot.com/bug?id=a66f45e96fdbeb76b796bf46eb25ea878c42a6c9 Link: http://lkml.kernel.org/r/[email protected] Signed-off-by: Tetsuo Handa <[email protected]> Reported-by: syzbot <[email protected]> Cc: Al Viro <[email protected]> Cc: David Howells <[email protected]> Cc: Ernesto A. Fernandez <[email protected]> Cc: Vyacheslav Dubeyko <[email protected]> Signed-off-by: Andrew Morton <[email protected]> Signed-off-by: Linus Torvalds <[email protected]>
1 parent ab1e8d8 commit 66072c2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

fs/hfsplus/super.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -588,6 +588,7 @@ static int hfsplus_fill_super(struct super_block *sb, void *data, int silent)
588588
return 0;
589589

590590
out_put_hidden_dir:
591+
cancel_delayed_work_sync(&sbi->sync_work);
591592
iput(sbi->hidden_dir);
592593
out_put_root:
593594
dput(sb->s_root);

0 commit comments

Comments
 (0)