Skip to content

Commit 664eadd

Browse files
groeckKalle Valo
authored andcommitted
bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets
Mips builds with BCMA host mode enabled fail in mainline and -next with: In file included from include/linux/bcma/bcma.h:10:0, from drivers/bcma/bcma_private.h:9, from drivers/bcma/main.c:8: include/linux/bcma/bcma_driver_pci.h:218:24: error: field 'pci_controller' has incomplete type Bisect points to commit d41e685 ("MIPS: Kconfig: Set default MIPS system type as generic") as the culprit. Analysis shows that the commmit changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only defined if PCI_DRIVERS_LEGACY is enabled. Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on PCI_DRIVERS_LEGACY. Add the missing dependency. Fixes: d41e685 ("MIPS: Kconfig: Set default MIPS system type as ...") Cc: Matt Redfearn <[email protected]> Cc: James Hogan <[email protected]> Signed-off-by: Guenter Roeck <[email protected]> Reviewed-by: James Hogan <[email protected]> Signed-off-by: Kalle Valo <[email protected]>
1 parent 49fdde8 commit 664eadd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/bcma/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ config BCMA_DRIVER_PCI
5555

5656
config BCMA_DRIVER_PCI_HOSTMODE
5757
bool "Driver for PCI core working in hostmode"
58-
depends on MIPS && BCMA_DRIVER_PCI
58+
depends on MIPS && BCMA_DRIVER_PCI && PCI_DRIVERS_LEGACY
5959
help
6060
PCI core hostmode operation (external PCI bus).
6161

0 commit comments

Comments
 (0)