Skip to content

Commit 6704a3a

Browse files
jacob-kellerJeff Kirsher
authored andcommitted
ixgbe: prevent ptp_rx_hang from running when in FILTER_ALL mode
On hardware which supports timestamping all packets, the timestamps are recorded in the packet buffer, and the driver no longer uses or reads the registers. This makes the logic for checking and clearing Rx timestamp hangs meaningless. If we run the ixgbe_ptp_rx_hang() function in this case, then the driver will continuously spam the log output with "Clearing Rx timestamp hang". These messages are spurious, and confusing to end users. The original code in commit a9763f3 ("ixgbe: Update PTP to support X550EM_x devices", 2015-12-03) did have a flag PTP_RX_TIMESTAMP_IN_REGISTER which was intended to be used to avoid the Rx timestamp hang check, however it did not actually check the flag before calling the function. Do so now in order to stop the checks and prevent the spurious log messages. Fixes: a9763f3 ("ixgbe: Update PTP to support X550EM_x devices", 2015-12-03) Signed-off-by: Jacob Keller <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 60f4b64 commit 6704a3a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7703,7 +7703,8 @@ static void ixgbe_service_task(struct work_struct *work)
77037703

77047704
if (test_bit(__IXGBE_PTP_RUNNING, &adapter->state)) {
77057705
ixgbe_ptp_overflow_check(adapter);
7706-
ixgbe_ptp_rx_hang(adapter);
7706+
if (adapter->flags & IXGBE_FLAG_RX_HWTSTAMP_IN_REGISTER)
7707+
ixgbe_ptp_rx_hang(adapter);
77077708
ixgbe_ptp_tx_hang(adapter);
77087709
}
77097710

0 commit comments

Comments
 (0)