Skip to content

Commit 677d85e

Browse files
ivoshopovBartosz Golaszewski
authored andcommitted
tools: gpio: fix -c option of gpio-event-mon
Following line should listen for a rising edge and exit after the first one since '-c 1' is provided. # gpio-event-mon -n gpiochip1 -o 0 -r -c 1 It works with kernel 4.19 but it doesn't work with 5.10. In 5.10 the above command doesn't exit after the first rising edge it keep listening for an event forever. The '-c 1' is not taken into an account. The problem is in commit 62757c3 ("tools: gpio: add multi-line monitoring to gpio-event-mon"). Before this commit the iterator 'i' in monitor_device() is used for counting of the events (loops). In the case of the above command (-c 1) we should start from 0 and increment 'i' only ones and hit the 'break' statement and exit the process. But after the above commit counting doesn't start from 0, it start from 1 when we listen on one line. It is because 'i' is used from one more purpose, counting of lines (num_lines) and it isn't restore to 0 after following code for (i = 0; i < num_lines; i++) gpiotools_set_bit(&values.mask, i); Restore the initial value of the iterator to 0 in order to allow counting of loops to work for any cases. Fixes: 62757c3 ("tools: gpio: add multi-line monitoring to gpio-event-mon") Signed-off-by: Ivo Borisov Shopov <[email protected]> Reviewed-by: Andy Shevchenko <[email protected]> [Bartosz: tweak the commit message] Signed-off-by: Bartosz Golaszewski <[email protected]>
1 parent b710ef4 commit 677d85e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/gpio/gpio-event-mon.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ int monitor_device(const char *device_name,
8686
gpiotools_test_bit(values.bits, i));
8787
}
8888

89+
i = 0;
8990
while (1) {
9091
struct gpio_v2_line_event event;
9192

0 commit comments

Comments
 (0)