Skip to content

Commit 68ae742

Browse files
Alexander DuyckJeff Kirsher
authored andcommitted
ixgbe: Drop l2_accel_priv data pointer from ring struct
The l2 acceleration private pointer isn't needed in the ring struct. It isn't really used anywhere other than to test and see if we are supporting an offloaded macvlan netdev, and it is much easier to test netdev for not being ixgbe based to verify that. Signed-off-by: Alexander Duyck <[email protected]> Tested-by: Andrew Bowers <[email protected]> Signed-off-by: Jeff Kirsher <[email protected]>
1 parent 1489542 commit 68ae742

File tree

2 files changed

+13
-11
lines changed

2 files changed

+13
-11
lines changed

drivers/net/ethernet/intel/ixgbe/ixgbe.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,6 @@ struct ixgbe_ring {
333333
struct net_device *netdev; /* netdev ring belongs to */
334334
struct bpf_prog *xdp_prog;
335335
struct device *dev; /* device for DMA mapping */
336-
struct ixgbe_fwd_adapter *l2_accel_priv;
337336
void *desc; /* descriptor ring memory */
338337
union {
339338
struct ixgbe_tx_buffer *tx_buffer_info;

drivers/net/ethernet/intel/ixgbe/ixgbe_main.c

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -192,6 +192,13 @@ static struct workqueue_struct *ixgbe_wq;
192192
static bool ixgbe_check_cfg_remove(struct ixgbe_hw *hw, struct pci_dev *pdev);
193193
static void ixgbe_watchdog_link_is_down(struct ixgbe_adapter *);
194194

195+
static const struct net_device_ops ixgbe_netdev_ops;
196+
197+
static bool netif_is_ixgbe(struct net_device *dev)
198+
{
199+
return dev && (dev->netdev_ops == &ixgbe_netdev_ops);
200+
}
201+
195202
static int ixgbe_read_pci_cfg_word_parent(struct ixgbe_adapter *adapter,
196203
u32 reg, u16 *value)
197204
{
@@ -4481,8 +4488,9 @@ static void ixgbe_vlan_strip_disable(struct ixgbe_adapter *adapter)
44814488
for (i = 0; i < adapter->num_rx_queues; i++) {
44824489
struct ixgbe_ring *ring = adapter->rx_ring[i];
44834490

4484-
if (ring->l2_accel_priv)
4491+
if (!netif_is_ixgbe(ring->netdev))
44854492
continue;
4493+
44864494
j = ring->reg_idx;
44874495
vlnctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(j));
44884496
vlnctrl &= ~IXGBE_RXDCTL_VME;
@@ -4518,8 +4526,9 @@ static void ixgbe_vlan_strip_enable(struct ixgbe_adapter *adapter)
45184526
for (i = 0; i < adapter->num_rx_queues; i++) {
45194527
struct ixgbe_ring *ring = adapter->rx_ring[i];
45204528

4521-
if (ring->l2_accel_priv)
4529+
if (!netif_is_ixgbe(ring->netdev))
45224530
continue;
4531+
45234532
j = ring->reg_idx;
45244533
vlnctrl = IXGBE_READ_REG(hw, IXGBE_RXDCTL(j));
45254534
vlnctrl |= IXGBE_RXDCTL_VME;
@@ -5333,7 +5342,6 @@ static void ixgbe_disable_fwd_ring(struct ixgbe_fwd_adapter *vadapter,
53335342
usleep_range(10000, 20000);
53345343
ixgbe_irq_disable_queues(adapter, BIT_ULL(index));
53355344
ixgbe_clean_rx_ring(rx_ring);
5336-
rx_ring->l2_accel_priv = NULL;
53375345
}
53385346

53395347
static int ixgbe_fwd_ring_down(struct net_device *vdev,
@@ -5351,10 +5359,8 @@ static int ixgbe_fwd_ring_down(struct net_device *vdev,
53515359
adapter->rx_ring[rxbase + i]->netdev = adapter->netdev;
53525360
}
53535361

5354-
for (i = 0; i < adapter->num_rx_queues_per_pool; i++) {
5355-
adapter->tx_ring[txbase + i]->l2_accel_priv = NULL;
5362+
for (i = 0; i < adapter->num_rx_queues_per_pool; i++)
53565363
adapter->tx_ring[txbase + i]->netdev = adapter->netdev;
5357-
}
53585364

53595365

53605366
return 0;
@@ -5384,14 +5390,11 @@ static int ixgbe_fwd_ring_up(struct net_device *vdev,
53845390

53855391
for (i = 0; i < adapter->num_rx_queues_per_pool; i++) {
53865392
adapter->rx_ring[rxbase + i]->netdev = vdev;
5387-
adapter->rx_ring[rxbase + i]->l2_accel_priv = accel;
53885393
ixgbe_configure_rx_ring(adapter, adapter->rx_ring[rxbase + i]);
53895394
}
53905395

5391-
for (i = 0; i < adapter->num_rx_queues_per_pool; i++) {
5396+
for (i = 0; i < adapter->num_rx_queues_per_pool; i++)
53925397
adapter->tx_ring[txbase + i]->netdev = vdev;
5393-
adapter->tx_ring[txbase + i]->l2_accel_priv = accel;
5394-
}
53955398

53965399
queues = min_t(unsigned int,
53975400
adapter->num_rx_queues_per_pool, vdev->num_tx_queues);

0 commit comments

Comments
 (0)