Skip to content

Commit 68af490

Browse files
andy-shevgregkh
authored andcommitted
serial: 8250: enable AFE on ports where FIFO is 16 bytes
Intel Quark has 16550A compatible UART with autoflow feature enabled. It has only 16 bytes of FIFO. Currently serial8250_do_set_termios() prevents to enable autoflow since the minimum requirement of 32 bytes of FIFO size. Drop a FIFO size limitation to allow autoflow control be enabled on such UARTs. While here, comment out UART_CAP_AFE for PORT_AR7 since it wasn't working and it will be not a good idea to use it in conjunction with trigger level of 1 byte. Suggested-by: Peter Hurley <[email protected]> Reviewed-by: Peter Hurley <[email protected]> Signed-off-by: Andy Shevchenko <[email protected]> Tested-by: Bryan O'Donoghue <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent d1834ba commit 68af490

File tree

1 file changed

+3
-6
lines changed

1 file changed

+3
-6
lines changed

drivers/tty/serial/8250/8250_port.c

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -178,7 +178,7 @@ static const struct serial8250_config uart_config[] = {
178178
.fifo_size = 16,
179179
.tx_loadsz = 16,
180180
.fcr = UART_FCR_ENABLE_FIFO | UART_FCR_R_TRIG_00,
181-
.flags = UART_CAP_FIFO | UART_CAP_AFE,
181+
.flags = UART_CAP_FIFO /* | UART_CAP_AFE */,
182182
},
183183
[PORT_U6_16550A] = {
184184
.name = "U6_16550A",
@@ -2549,12 +2549,9 @@ serial8250_do_set_termios(struct uart_port *port, struct ktermios *termios,
25492549
/*
25502550
* MCR-based auto flow control. When AFE is enabled, RTS will be
25512551
* deasserted when the receive FIFO contains more characters than
2552-
* the trigger, or the MCR RTS bit is cleared. In the case where
2553-
* the remote UART is not using CTS auto flow control, we must
2554-
* have sufficient FIFO entries for the latency of the remote
2555-
* UART to respond. IOW, at least 32 bytes of FIFO.
2552+
* the trigger, or the MCR RTS bit is cleared.
25562553
*/
2557-
if (up->capabilities & UART_CAP_AFE && port->fifosize >= 32) {
2554+
if (up->capabilities & UART_CAP_AFE) {
25582555
up->mcr &= ~UART_MCR_AFE;
25592556
if (termios->c_cflag & CRTSCTS)
25602557
up->mcr |= UART_MCR_AFE;

0 commit comments

Comments
 (0)