Skip to content

Commit 68d19d7

Browse files
holtmannJohan Hedberg
authored andcommitted
Revert "Bluetooth: validate BLE connection interval updates"
This reverts commit c49a868. There are devices which require low connection intervals for usable operation including keyboards and mice. Forcing a static connection interval for these types of devices has an impact in latency and causes a regression. Signed-off-by: Marcel Holtmann <[email protected]> Signed-off-by: Johan Hedberg <[email protected]>
1 parent d94dfd7 commit 68d19d7

File tree

2 files changed

+1
-13
lines changed

2 files changed

+1
-13
lines changed

net/bluetooth/hci_event.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5660,11 +5660,6 @@ static void hci_le_remote_conn_param_req_evt(struct hci_dev *hdev,
56605660
return send_conn_param_neg_reply(hdev, handle,
56615661
HCI_ERROR_UNKNOWN_CONN_ID);
56625662

5663-
if (min < hcon->le_conn_min_interval ||
5664-
max > hcon->le_conn_max_interval)
5665-
return send_conn_param_neg_reply(hdev, handle,
5666-
HCI_ERROR_INVALID_LL_PARAMS);
5667-
56685663
if (hci_check_conn_params(min, max, latency, timeout))
56695664
return send_conn_param_neg_reply(hdev, handle,
56705665
HCI_ERROR_INVALID_LL_PARAMS);

net/bluetooth/l2cap_core.c

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5305,14 +5305,7 @@ static inline int l2cap_conn_param_update_req(struct l2cap_conn *conn,
53055305

53065306
memset(&rsp, 0, sizeof(rsp));
53075307

5308-
if (min < hcon->le_conn_min_interval ||
5309-
max > hcon->le_conn_max_interval) {
5310-
BT_DBG("requested connection interval exceeds current bounds.");
5311-
err = -EINVAL;
5312-
} else {
5313-
err = hci_check_conn_params(min, max, latency, to_multiplier);
5314-
}
5315-
5308+
err = hci_check_conn_params(min, max, latency, to_multiplier);
53165309
if (err)
53175310
rsp.result = cpu_to_le16(L2CAP_CONN_PARAM_REJECTED);
53185311
else

0 commit comments

Comments
 (0)