Skip to content

Commit 6963c58

Browse files
committed
ARM: OMAP2+: Fix MMC address space mismatch for am33xx and am43xx
The address space currently set up for the interconnect data is different compared to the dts data. We have hwmod data with offset 0x100 to account for the revision, sysc and syss register offsets. Let's fix the issue by correcting the MMC register offsets in hwmod data and removing the unnecessary duplicate IO range data that we get from device tree anyways. Cc: Lokesh Vutla <[email protected]> Cc: Paul Walmsley <[email protected]> Cc: Tero Kristo <[email protected]> Signed-off-by: Tony Lindgren <[email protected]>
1 parent 2bd6bf0 commit 6963c58

File tree

2 files changed

+3
-33
lines changed

2 files changed

+3
-33
lines changed

arch/arm/mach-omap2/omap_hwmod_33xx_43xx_interconnect_data.c

Lines changed: 0 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -286,56 +286,26 @@ struct omap_hwmod_ocp_if am33xx_l4_ls__mcasp1 = {
286286
};
287287

288288
/* l4 ls -> mmc0 */
289-
static struct omap_hwmod_addr_space am33xx_mmc0_addr_space[] = {
290-
{
291-
.pa_start = 0x48060100,
292-
.pa_end = 0x48060100 + SZ_4K - 1,
293-
.flags = ADDR_TYPE_RT,
294-
},
295-
{ }
296-
};
297-
298289
struct omap_hwmod_ocp_if am33xx_l4_ls__mmc0 = {
299290
.master = &am33xx_l4_ls_hwmod,
300291
.slave = &am33xx_mmc0_hwmod,
301292
.clk = "l4ls_gclk",
302-
.addr = am33xx_mmc0_addr_space,
303293
.user = OCP_USER_MPU,
304294
};
305295

306296
/* l4 ls -> mmc1 */
307-
static struct omap_hwmod_addr_space am33xx_mmc1_addr_space[] = {
308-
{
309-
.pa_start = 0x481d8100,
310-
.pa_end = 0x481d8100 + SZ_4K - 1,
311-
.flags = ADDR_TYPE_RT,
312-
},
313-
{ }
314-
};
315-
316297
struct omap_hwmod_ocp_if am33xx_l4_ls__mmc1 = {
317298
.master = &am33xx_l4_ls_hwmod,
318299
.slave = &am33xx_mmc1_hwmod,
319300
.clk = "l4ls_gclk",
320-
.addr = am33xx_mmc1_addr_space,
321301
.user = OCP_USER_MPU,
322302
};
323303

324304
/* l3 s -> mmc2 */
325-
static struct omap_hwmod_addr_space am33xx_mmc2_addr_space[] = {
326-
{
327-
.pa_start = 0x47810100,
328-
.pa_end = 0x47810100 + SZ_64K - 1,
329-
.flags = ADDR_TYPE_RT,
330-
},
331-
{ }
332-
};
333-
334305
struct omap_hwmod_ocp_if am33xx_l3_s__mmc2 = {
335306
.master = &am33xx_l3_s_hwmod,
336307
.slave = &am33xx_mmc2_hwmod,
337308
.clk = "l3s_gclk",
338-
.addr = am33xx_mmc2_addr_space,
339309
.user = OCP_USER_MPU,
340310
};
341311

arch/arm/mach-omap2/omap_hwmod_33xx_43xx_ipblock_data.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -778,9 +778,9 @@ struct omap_hwmod am33xx_mcasp1_hwmod = {
778778

779779
/* 'mmc' class */
780780
static struct omap_hwmod_class_sysconfig am33xx_mmc_sysc = {
781-
.rev_offs = 0x1fc,
782-
.sysc_offs = 0x10,
783-
.syss_offs = 0x14,
781+
.rev_offs = 0x2fc,
782+
.sysc_offs = 0x110,
783+
.syss_offs = 0x114,
784784
.sysc_flags = (SYSC_HAS_CLOCKACTIVITY | SYSC_HAS_SIDLEMODE |
785785
SYSC_HAS_ENAWAKEUP | SYSC_HAS_SOFTRESET |
786786
SYSC_HAS_AUTOIDLE | SYSS_HAS_RESET_STATUS),

0 commit comments

Comments
 (0)