Skip to content

Commit 69a3300

Browse files
fishilicoKAGA-KOKO
authored andcommitted
RAS/CEC: Use the right length for "cec_disable"
parse_cec_param() compares a string with "cec_disable" using only 7 characters of the 11-character-long string. The proper solution for this would be: #define CEC_DISABLE "cec_disable" strncmp(str, CEC_DISABLE, strlen(CEC_DISABLE)) but when comparing a string against a string constant strncmp() has no advantage over strcmp() because the comparison is guaranteed to be bound by the string constant. So just replace str strncmp() with strcmp(). [ tglx: Made it use strcmp and updated the changelog ] Fixes: 011d826 ("RAS: Add a Corrected Errors Collector") Signed-off-by: Nicolas Iooss <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Signed-off-by: Thomas Gleixner <[email protected]> Cc: [email protected] Link: http://lkml.kernel.org/r/[email protected]
1 parent d81fa66 commit 69a3300

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/ras/cec.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -523,7 +523,7 @@ int __init parse_cec_param(char *str)
523523
if (*str == '=')
524524
str++;
525525

526-
if (!strncmp(str, "cec_disable", 7))
526+
if (!strcmp(str, "cec_disable"))
527527
ce_arr.disabled = 1;
528528
else
529529
return 0;

0 commit comments

Comments
 (0)