Skip to content

Commit 69b4ed5

Browse files
zx2c4davem330
authored andcommitted
net: sfc: use skb_list_walk_safe helper for gso segments
This is a straight-forward conversion case for the new function, and while we're at it, we can remove a null write to skb->next by replacing it with skb_mark_not_on_list. Signed-off-by: Jason A. Donenfeld <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 90919f1 commit 69b4ed5

File tree

1 file changed

+2
-5
lines changed
  • drivers/net/ethernet/sfc

1 file changed

+2
-5
lines changed

drivers/net/ethernet/sfc/tx.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -307,12 +307,9 @@ static int efx_tx_tso_fallback(struct efx_tx_queue *tx_queue,
307307
dev_consume_skb_any(skb);
308308
skb = segments;
309309

310-
while (skb) {
311-
next = skb->next;
312-
skb->next = NULL;
313-
310+
skb_list_walk_safe(skb, skb, next) {
311+
skb_mark_not_on_list(skb);
314312
efx_enqueue_skb(tx_queue, skb);
315-
skb = next;
316313
}
317314

318315
return 0;

0 commit comments

Comments
 (0)