Skip to content

Commit 69bf531

Browse files
Tomas Winklergregkh
authored andcommitted
mei: bus: fix hw module get/put balance
In case the device is not connected it doesn't 'get' hw module and hence should not 'put' it on disable. Cc: <[email protected]> 4.16+ Fixes:'commit 257355a ("mei: make module referencing local to the bus.c")' Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=200455 Tested-by: Georg Müller <[email protected]> Signed-off-by: Tomas Winkler <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent c1a214a commit 69bf531

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

drivers/misc/mei/bus.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -616,9 +616,8 @@ int mei_cldev_disable(struct mei_cl_device *cldev)
616616
if (err < 0)
617617
dev_err(bus->dev, "Could not disconnect from the ME client\n");
618618

619-
out:
620619
mei_cl_bus_module_put(cldev);
621-
620+
out:
622621
/* Flush queues and remove any pending read */
623622
mei_cl_flush_queues(cl, NULL);
624623
mei_cl_unlink(cl);

0 commit comments

Comments
 (0)