Skip to content

Commit 6a62c92

Browse files
gerd-rauschjfvogel
authored andcommitted
Revert "net/rds: Allocate pages on HCA NUMA nodeid"
This reverts commit 7692fc72b66f97feb3d00d34f3fcd1a24605c18c. Orabug: 33590962 Signed-off-by: Gerd Rausch <[email protected]> Reviewed-by: John Donnelly <[email protected]> Signed-off-by: Brian Maly <[email protected]> Orabug: 33590097 UEK6 => UEK7 (cherry picked from commit 9674470) cherry-pick-repo=UEK/production/linux-uek.git Signed-off-by: Gerd Rausch <[email protected]> Reviewed-by: William Kucharski <[email protected]>
1 parent 73c6123 commit 6a62c92

File tree

5 files changed

+10
-12
lines changed

5 files changed

+10
-12
lines changed

net/rds/ib_cm.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -967,8 +967,7 @@ static int rds_ib_alloc_map_hdrs(struct ib_device *dev,
967967
}
968968

969969
for (i = 0; i < nmbr_hdr_pages; i++) {
970-
ret = rds_page_remainder_alloc(sg + i, PAGE_SIZE, GFP_KERNEL,
971-
ibdev_to_node(dev));
970+
ret = rds_page_remainder_alloc(sg + i, PAGE_SIZE, GFP_KERNEL);
972971
if (ret) {
973972
*reason = "rds_page_remainder_alloc failed";
974973
for (j = 0; j < i; ++j)

net/rds/ib_recv.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -295,8 +295,8 @@ static struct rds_page_frag *rds_ib_refill_one_frag(struct rds_ib_connection *ic
295295

296296
sg_init_table(frag->f_sg, ic->i_frag_pages);
297297
for_each_sg(frag->f_sg, sg, ic->i_frag_pages, i) {
298-
ret = rds_page_remainder_alloc(sg, PAGE_SIZE, page_mask,
299-
rdsibdev_to_node(ic->rds_ibdev));
298+
ret = rds_page_remainder_alloc(sg,
299+
PAGE_SIZE, page_mask);
300300
if (ret) {
301301
for_each_sg(frag->f_sg, s, ic->i_frag_pages, j) {
302302
/* Its the ith fragment we couldn't allocate */
@@ -471,8 +471,8 @@ static int rds_ib_srq_prefill_one(struct rds_ib_device *rds_ibdev,
471471
goto out;
472472
sg_init_table(recv->r_frag->f_sg, num_sge);
473473
for_each_sg(recv->r_frag->f_sg, sg, num_sge, i) {
474-
ret = rds_page_remainder_alloc(sg, PAGE_SIZE, page_mask,
475-
rdsibdev_to_node(rds_ibdev));
474+
ret = rds_page_remainder_alloc(sg,
475+
PAGE_SIZE, page_mask);
476476
if (ret) {
477477
for_each_sg(recv->r_frag->f_sg, s, num_sge, j)
478478
/* Its the ith fragment we couldn't allocate */

net/rds/message.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -314,8 +314,7 @@ int rds_message_copy_from_user(struct rds_message *rm, struct iov_iter *from,
314314
if (!sg_page(sg)) {
315315
ret = rds_page_remainder_alloc(sg, iov_iter_count(from),
316316
GFP_ATOMIC == gfp ?
317-
gfp : GFP_HIGHUSER,
318-
NUMA_NO_NODE);
317+
gfp : GFP_HIGHUSER);
319318

320319
if (ret)
321320
return ret;

net/rds/page.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ DEFINE_PER_CPU(struct rds_page_remainder, rds_page_remainders) ____cacheline_ali
6262
* reference until they are done with the region.
6363
*/
6464
int rds_page_remainder_alloc(struct scatterlist *scat, unsigned long bytes,
65-
gfp_t gfp, int nid)
65+
gfp_t gfp)
6666
{
6767
struct rds_page_remainder *rem;
6868
unsigned long flags;
@@ -73,7 +73,7 @@ int rds_page_remainder_alloc(struct scatterlist *scat, unsigned long bytes,
7373

7474
/* jump straight to allocation if we're trying for a huge page */
7575
if (bytes >= PAGE_SIZE) {
76-
page = alloc_pages_node(nid, gfp, 0);
76+
page = alloc_page(gfp);
7777
if (!page) {
7878
ret = -ENOMEM;
7979
} else {
@@ -118,7 +118,7 @@ int rds_page_remainder_alloc(struct scatterlist *scat, unsigned long bytes,
118118
local_irq_restore(flags);
119119
put_cpu();
120120

121-
page = alloc_pages_node(nid, gfp, 0);
121+
page = alloc_page(gfp);
122122

123123
rem = &per_cpu(rds_page_remainders, get_cpu());
124124
local_irq_save(flags);

net/rds/rds.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1303,7 +1303,7 @@ void rds_rt_debug_tp_enable(void);
13031303

13041304
/* page.c */
13051305
int rds_page_remainder_alloc(struct scatterlist *scat, unsigned long bytes,
1306-
gfp_t gfp, int nid);
1306+
gfp_t gfp);
13071307
void rds_page_exit(void);
13081308

13091309
/* recv.c */

0 commit comments

Comments
 (0)