netfilter: Fix format string of nfnetlink_queue proc file

richardweinberger · davem330 · commit 6b46f7b7e97e · 2015-04-13T16:35:16.000-04:00
The printed values are all of type unsigned integer, therefore use
%u instead of %d. Otherwise an user can face negative values.

Fixes:
$ cat /proc/net/netfilter/nfnetlink_queue
    0  29508   278 2 65531     0 2004213241 -2129885586  1
    1 -27747     0 2 65531     0     0        0  1
    2 -27748     0 2 65531     0     0        0  1

Signed-off-by: Richard Weinberger &lt;richard@nod.at&gt;
Acked-by: Pablo Neira Ayuso &lt;pablo@netfilter.org&gt;
Signed-off-by: David S. Miller &lt;davem@davemloft.net&gt;
diff --git a/net/netfilter/nfnetlink_queue_core.c b/net/netfilter/nfnetlink_queue_core.c
@@ -1251,7 +1251,7 @@ static int seq_show(struct seq_file *s, void *v)
 {
 	const struct nfqnl_instance *inst = v;
 
-	seq_printf(s, "%5d %6d %5d %1d %5d %5d %5d %8d %2d\n",
+	seq_printf(s, "%5u %6u %5u %1u %5u %5u %5u %8u %2d\n",
 		   inst->queue_num,
 		   inst->peer_portid, inst->queue_total,
 		   inst->copy_mode, inst->copy_range,

Original file line number	Diff line number	Diff line change
`@@ -1251,7 +1251,7 @@ static int seq_show(struct seq_file s, void v)`
`1251`	`1251`	`{`
`1252`	`1252`	`const struct nfqnl_instance *inst = v;`
`1253`	`1253`
`1254`		`- seq_printf(s, "%5d %6d %5d %1d %5d %5d %5d %8d %2d\n",`
	`1254`	`+ seq_printf(s, "%5u %6u %5u %1u %5u %5u %5u %8u %2d\n",`
`1255`	`1255`	`inst->queue_num,`
`1256`	`1256`	`inst->peer_portid, inst->queue_total,`
`1257`	`1257`	`inst->copy_mode, inst->copy_range,`