Skip to content

Commit 6b5aa88

Browse files
committed
Merge branch 'fix/fst-sysfs' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5
Signed-off-by: Chris Mason <[email protected]>
2 parents a6111d1 + 14e46e0 commit 6b5aa88

File tree

6 files changed

+53
-1
lines changed

6 files changed

+53
-1
lines changed

fs/btrfs/free-space-tree.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
#include "locking.h"
2424
#include "free-space-tree.h"
2525
#include "transaction.h"
26+
#include "sysfs.h"
2627

2728
static int __add_block_group_free_space(struct btrfs_trans_handle *trans,
2829
struct btrfs_fs_info *fs_info,
@@ -1169,6 +1170,9 @@ int btrfs_create_free_space_tree(struct btrfs_fs_info *fs_info)
11691170
}
11701171

11711172
btrfs_set_fs_compat_ro(fs_info, FREE_SPACE_TREE);
1173+
btrfs_sysfs_feature_update(fs_info,
1174+
BTRFS_FEATURE_COMPAT_RO_FREE_SPACE_TREE, FEAT_COMPAT_RO);
1175+
11721176
fs_info->creating_free_space_tree = 0;
11731177

11741178
ret = btrfs_commit_transaction(trans, tree_root);
@@ -1237,6 +1241,9 @@ int btrfs_clear_free_space_tree(struct btrfs_fs_info *fs_info)
12371241
return PTR_ERR(trans);
12381242

12391243
btrfs_clear_fs_compat_ro(fs_info, FREE_SPACE_TREE);
1244+
btrfs_sysfs_feature_update(fs_info,
1245+
BTRFS_FEATURE_COMPAT_RO_FREE_SPACE_TREE, FEAT_COMPAT_RO);
1246+
12401247
fs_info->free_space_root = NULL;
12411248

12421249
ret = clear_free_space_tree(trans, free_space_root);

fs/btrfs/ioctl.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1459,6 +1459,8 @@ int btrfs_defrag_file(struct inode *inode, struct file *file,
14591459

14601460
if (range->compress_type == BTRFS_COMPRESS_LZO) {
14611461
btrfs_set_fs_incompat(root->fs_info, COMPRESS_LZO);
1462+
btrfs_sysfs_feature_update(root->fs_info,
1463+
BTRFS_FEATURE_INCOMPAT_COMPRESS_LZO, FEAT_INCOMPAT);
14621464
}
14631465

14641466
ret = defrag_count;
@@ -4067,6 +4069,8 @@ static long btrfs_ioctl_default_subvol(struct file *file, void __user *argp)
40674069
btrfs_free_path(path);
40684070

40694071
btrfs_set_fs_incompat(root->fs_info, DEFAULT_SUBVOL);
4072+
btrfs_sysfs_feature_update(root->fs_info,
4073+
BTRFS_FEATURE_INCOMPAT_DEFAULT_SUBVOL, FEAT_INCOMPAT);
40704074
btrfs_end_transaction(trans, root);
40714075
out:
40724076
mnt_drop_write_file(file);

fs/btrfs/super.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@
5858
#include "dev-replace.h"
5959
#include "free-space-cache.h"
6060
#include "backref.h"
61+
#include "sysfs.h"
6162
#include "tests/btrfs-tests.h"
6263

6364
#include "qgroup.h"
@@ -485,6 +486,9 @@ int btrfs_parse_options(struct btrfs_root *root, char *options)
485486
btrfs_clear_opt(info->mount_opt, NODATACOW);
486487
btrfs_clear_opt(info->mount_opt, NODATASUM);
487488
btrfs_set_fs_incompat(info, COMPRESS_LZO);
489+
btrfs_sysfs_feature_update(root->fs_info,
490+
BTRFS_FEATURE_INCOMPAT_COMPRESS_LZO,
491+
FEAT_INCOMPAT);
488492
no_compress = 0;
489493
} else if (strncmp(args[0].from, "no", 2) == 0) {
490494
compress_type = "no";

fs/btrfs/sysfs.c

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -202,6 +202,7 @@ BTRFS_FEAT_ATTR_INCOMPAT(extended_iref, EXTENDED_IREF);
202202
BTRFS_FEAT_ATTR_INCOMPAT(raid56, RAID56);
203203
BTRFS_FEAT_ATTR_INCOMPAT(skinny_metadata, SKINNY_METADATA);
204204
BTRFS_FEAT_ATTR_INCOMPAT(no_holes, NO_HOLES);
205+
BTRFS_FEAT_ATTR_COMPAT_RO(free_space_tree, FREE_SPACE_TREE);
205206

206207
static struct attribute *btrfs_supported_feature_attrs[] = {
207208
BTRFS_FEAT_ATTR_PTR(mixed_backref),
@@ -213,6 +214,7 @@ static struct attribute *btrfs_supported_feature_attrs[] = {
213214
BTRFS_FEAT_ATTR_PTR(raid56),
214215
BTRFS_FEAT_ATTR_PTR(skinny_metadata),
215216
BTRFS_FEAT_ATTR_PTR(no_holes),
217+
BTRFS_FEAT_ATTR_PTR(free_space_tree),
216218
NULL
217219
};
218220

@@ -780,6 +782,36 @@ int btrfs_sysfs_add_mounted(struct btrfs_fs_info *fs_info)
780782
return error;
781783
}
782784

785+
786+
/*
787+
* Change per-fs features in /sys/fs/btrfs/UUID/features to match current
788+
* values in superblock. Call after any changes to incompat/compat_ro flags
789+
*/
790+
void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info,
791+
u64 bit, enum btrfs_feature_set set)
792+
{
793+
struct btrfs_fs_devices *fs_devs;
794+
struct kobject *fsid_kobj;
795+
u64 features;
796+
int ret;
797+
798+
if (!fs_info)
799+
return;
800+
801+
features = get_features(fs_info, set);
802+
ASSERT(bit & supported_feature_masks[set]);
803+
804+
fs_devs = fs_info->fs_devices;
805+
fsid_kobj = &fs_devs->fsid_kobj;
806+
807+
/*
808+
* FIXME: this is too heavy to update just one value, ideally we'd like
809+
* to use sysfs_update_group but some refactoring is needed first.
810+
*/
811+
sysfs_remove_group(fsid_kobj, &btrfs_feature_attr_group);
812+
ret = sysfs_create_group(fsid_kobj, &btrfs_feature_attr_group);
813+
}
814+
783815
static int btrfs_init_debugfs(void)
784816
{
785817
#ifdef CONFIG_DEBUG_FS

fs/btrfs/sysfs.h

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ static struct btrfs_feature_attr btrfs_attr_##_name = { \
5656
#define BTRFS_FEAT_ATTR_COMPAT(name, feature) \
5757
BTRFS_FEAT_ATTR(name, FEAT_COMPAT, BTRFS_FEATURE_COMPAT, feature)
5858
#define BTRFS_FEAT_ATTR_COMPAT_RO(name, feature) \
59-
BTRFS_FEAT_ATTR(name, FEAT_COMPAT_RO, BTRFS_FEATURE_COMPAT, feature)
59+
BTRFS_FEAT_ATTR(name, FEAT_COMPAT_RO, BTRFS_FEATURE_COMPAT_RO, feature)
6060
#define BTRFS_FEAT_ATTR_INCOMPAT(name, feature) \
6161
BTRFS_FEAT_ATTR(name, FEAT_INCOMPAT, BTRFS_FEATURE_INCOMPAT, feature)
6262

@@ -90,4 +90,7 @@ int btrfs_sysfs_add_fsid(struct btrfs_fs_devices *fs_devs,
9090
struct kobject *parent);
9191
int btrfs_sysfs_add_device(struct btrfs_fs_devices *fs_devs);
9292
void btrfs_sysfs_remove_fsid(struct btrfs_fs_devices *fs_devs);
93+
void btrfs_sysfs_feature_update(struct btrfs_fs_info *fs_info,
94+
u64 bit, enum btrfs_feature_set set);
95+
9396
#endif /* _BTRFS_SYSFS_H_ */

fs/btrfs/volumes.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4469,6 +4469,8 @@ static void check_raid56_incompat_flag(struct btrfs_fs_info *info, u64 type)
44694469
return;
44704470

44714471
btrfs_set_fs_incompat(info, RAID56);
4472+
btrfs_sysfs_feature_update(info, BTRFS_FEATURE_INCOMPAT_RAID56,
4473+
FEAT_INCOMPAT);
44724474
}
44734475

44744476
#define BTRFS_MAX_DEVS(r) ((BTRFS_LEAF_DATA_SIZE(r) \

0 commit comments

Comments
 (0)