ALSA: firewire-motu: suppless consumption for unused element of array in stack

takaswie · tiwai · commit 6c1549c4cc3c · 2018-06-19T20:44:45.000+02:00
In MOTU firewire protocol, data block consists of 24 bit data chunks except
for one quadlet for source packet header (SPH). The number of data chunk in
a data block is different between three clock modes; low, middle and high.
When unit supports ADAT on optical interface, the data block includes some
chunks for ADAT channels. These ADAT chunks are unavailable at high mode.

This driver has local functions to calculate the number of ADAT chunks. But
They uses stack for three clock modes. This is useless for higher mode.

Signed-off-by: Takashi Sakamoto &lt;o-takashi@sakamocchi.jp&gt;
Signed-off-by: Takashi Iwai &lt;tiwai@suse.de&gt;
diff --git a/sound/firewire/motu/motu-protocol-v2.c b/sound/firewire/motu/motu-protocol-v2.c
@@ -176,7 +176,7 @@ static void calculate_differed_part(struct snd_motu_packet_format *formats,
 				    enum snd_motu_spec_flags flags,
 				    u32 data, u32 mask, u32 shift)
 {
-	unsigned char pcm_chunks[3] = {0, 0};
+	unsigned char pcm_chunks[2] = {0, 0};
 
 	/*
 	 * When optical interfaces are configured for S/PDIF (TOSLINK),

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ static void calculate_differed_part(struct snd_motu_packet_format *formats,`
`176`	`176`	`enum snd_motu_spec_flags flags,`
`177`	`177`	`u32 data, u32 mask, u32 shift)`
`178`	`178`	`{`
`179`		`- unsigned char pcm_chunks[3] = {0, 0};`
	`179`	`+ unsigned char pcm_chunks[2] = {0, 0};`
`180`	`180`
`181`	`181`	`/*`
`182`	`182`	`* When optical interfaces are configured for S/PDIF (TOSLINK),`