Skip to content

Commit 6c681f8

Browse files
Siddharth-Vadapalli-at-TIkuba-moo
authored andcommitted
net: ethernet: ti: am65-cpsw: Fix RGMII configuration at SPEED_10
The am65-cpsw driver supports configuring all RGMII variants at interface speed of 10 Mbps. However, in the process of shifting to the PHYLINK framework, the support for all variants of RGMII except the PHY_INTERFACE_MODE_RGMII variant was accidentally removed. Fix this by using phy_interface_mode_is_rgmii() to check for all variants of RGMII mode. Fixes: e8609e6 ("net: ethernet: ti: am65-cpsw: Convert to PHYLINK") Reported-by: Schuyler Patton <[email protected]> Signed-off-by: Siddharth Vadapalli <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
1 parent 421f866 commit 6c681f8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/net/ethernet/ti/am65-cpsw-nuss.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1454,7 +1454,7 @@ static void am65_cpsw_nuss_mac_link_up(struct phylink_config *config, struct phy
14541454

14551455
if (speed == SPEED_1000)
14561456
mac_control |= CPSW_SL_CTL_GIG;
1457-
if (speed == SPEED_10 && interface == PHY_INTERFACE_MODE_RGMII)
1457+
if (speed == SPEED_10 && phy_interface_mode_is_rgmii(interface))
14581458
/* Can be used with in band mode only */
14591459
mac_control |= CPSW_SL_CTL_EXT_EN;
14601460
if (speed == SPEED_100 && interface == PHY_INTERFACE_MODE_RMII)

0 commit comments

Comments
 (0)