Skip to content

Commit 6de6c1f

Browse files
tehnerdAlexei Starovoitov
authored andcommitted
bpf: Allow to change skb mark in test_run
allow to pass skb's mark field into bpf_prog_test_run ctx for BPF_PROG_TYPE_SCHED_CLS prog type. that would allow to test bpf programs which are doing decision based on this field Signed-off-by: Nikita V. Shirokov <[email protected]> Signed-off-by: Alexei Starovoitov <[email protected]>
1 parent dacce64 commit 6de6c1f

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

net/bpf/test_run.c

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,13 @@ static int convert___skb_to_skb(struct sk_buff *skb, struct __sk_buff *__skb)
251251
return 0;
252252

253253
/* make sure the fields we don't use are zeroed */
254-
if (!range_is_zero(__skb, 0, offsetof(struct __sk_buff, priority)))
254+
if (!range_is_zero(__skb, 0, offsetof(struct __sk_buff, mark)))
255+
return -EINVAL;
256+
257+
/* mark is allowed */
258+
259+
if (!range_is_zero(__skb, offsetofend(struct __sk_buff, mark),
260+
offsetof(struct __sk_buff, priority)))
255261
return -EINVAL;
256262

257263
/* priority is allowed */
@@ -274,6 +280,7 @@ static int convert___skb_to_skb(struct sk_buff *skb, struct __sk_buff *__skb)
274280
sizeof(struct __sk_buff)))
275281
return -EINVAL;
276282

283+
skb->mark = __skb->mark;
277284
skb->priority = __skb->priority;
278285
skb->tstamp = __skb->tstamp;
279286
memcpy(&cb->data, __skb->cb, QDISC_CB_PRIV_LEN);
@@ -301,6 +308,7 @@ static void convert_skb_to___skb(struct sk_buff *skb, struct __sk_buff *__skb)
301308
if (!__skb)
302309
return;
303310

311+
__skb->mark = skb->mark;
304312
__skb->priority = skb->priority;
305313
__skb->tstamp = skb->tstamp;
306314
memcpy(__skb->cb, &cb->data, QDISC_CB_PRIV_LEN);

tools/testing/selftests/bpf/prog_tests/skb_ctx.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@ void test_skb_ctx(void)
1313
.tstamp = 7,
1414
.wire_len = 100,
1515
.gso_segs = 8,
16+
.mark = 9,
1617
};
1718
struct bpf_prog_test_run_attr tattr = {
1819
.data_in = &pkt_v4,
@@ -93,4 +94,8 @@ void test_skb_ctx(void)
9394
"ctx_out_tstamp",
9495
"skb->tstamp == %lld, expected %d\n",
9596
skb.tstamp, 8);
97+
CHECK_ATTR(skb.mark != 10,
98+
"ctx_out_mark",
99+
"skb->mark == %u, expected %d\n",
100+
skb.mark, 10);
96101
}

tools/testing/selftests/bpf/progs/test_skb_ctx.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ int process(struct __sk_buff *skb)
1717
}
1818
skb->priority++;
1919
skb->tstamp++;
20+
skb->mark++;
2021

2122
if (skb->wire_len != 100)
2223
return 1;

0 commit comments

Comments
 (0)