Skip to content

Commit 6debce6

Browse files
borneoaJiri Kosina
authored andcommitted
HID: cp2112: fix to force single data-report reply
Current implementation of cp2112_raw_event() only accepts one data report at a time. If last received data report is not fully handled yet, a new incoming data report will overwrite it. In such case we don't guaranteed to propagate the correct incoming data. The trivial fix implemented here forces a single report at a time by requesting in cp2112_read() no more than 61 byte of data, which is the payload size of a single data report. Cc: [email protected] Signed-off-by: Antonio Borneo <[email protected]> Tested-by: Ellen Wang <[email protected]> Signed-off-by: Jiri Kosina <[email protected]>
1 parent 9633920 commit 6debce6

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

drivers/hid/hid-cp2112.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,8 @@ static int cp2112_read(struct cp2112_device *dev, u8 *data, size_t size)
356356
struct cp2112_force_read_report report;
357357
int ret;
358358

359+
if (size > sizeof(dev->read_data))
360+
size = sizeof(dev->read_data);
359361
report.report = CP2112_DATA_READ_FORCE_SEND;
360362
report.length = cpu_to_be16(size);
361363

0 commit comments

Comments
 (0)