ALSA: pcxhr: NULL dereference on probe failure

Dan Carpenter · tiwai · commit 6e1d7a51392f · 2014-12-10T14:45:22.000+01:00
"card" is NULL if snd_card_new() fails.

Signed-off-by: Dan Carpenter &lt;dan.carpenter@oracle.com&gt;
Signed-off-by: Takashi Iwai &lt;tiwai@suse.de&gt;
diff --git a/sound/pci/pcxhr/pcxhr.c b/sound/pci/pcxhr/pcxhr.c
@@ -1638,7 +1638,7 @@ static int pcxhr_probe(struct pci_dev *pci,
 				   0, &card);
 
 		if (err < 0) {
-			dev_err(card->dev, "cannot allocate the card %d\n", i);
+			dev_err(&pci->dev, "cannot allocate the card %d\n", i);
 			pcxhr_free(mgr);
 			return err;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1638,7 +1638,7 @@ static int pcxhr_probe(struct pci_dev *pci,`
`1638`	`1638`	`0, &card);`
`1639`	`1639`
`1640`	`1640`	`if (err < 0) {`
`1641`		`- dev_err(card->dev, "cannot allocate the card %d\n", i);`
	`1641`	`+ dev_err(&pci->dev, "cannot allocate the card %d\n", i);`
`1642`	`1642`	`pcxhr_free(mgr);`
`1643`	`1643`	`return err;`
`1644`	`1644`	`}`