Skip to content

Commit 6e6fbb7

Browse files
committed
Merge branch 'net-devlink-couple-of-trivial-fixes'
Jiri Pirko says: ==================== net: devlink: couple of trivial fixes Just a couple of trivial fixes I found on the way. ==================== Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Jakub Kicinski <[email protected]>
2 parents 816cd16 + a44c451 commit 6e6fbb7

File tree

3 files changed

+10
-14
lines changed

3 files changed

+10
-14
lines changed

drivers/net/ethernet/mellanox/mlxsw/spectrum_dpipe.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1266,10 +1266,8 @@ int mlxsw_sp_dpipe_init(struct mlxsw_sp *mlxsw_sp)
12661266
struct devlink *devlink = priv_to_devlink(mlxsw_sp->core);
12671267
int err;
12681268

1269-
err = devlink_dpipe_headers_register(devlink,
1270-
&mlxsw_sp_dpipe_headers);
1271-
if (err)
1272-
return err;
1269+
devlink_dpipe_headers_register(devlink, &mlxsw_sp_dpipe_headers);
1270+
12731271
err = mlxsw_sp_dpipe_erif_table_init(mlxsw_sp);
12741272
if (err)
12751273
goto err_erif_table_init;

include/net/devlink.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1590,7 +1590,7 @@ int devlink_dpipe_table_register(struct devlink *devlink,
15901590
void *priv, bool counter_control_extern);
15911591
void devlink_dpipe_table_unregister(struct devlink *devlink,
15921592
const char *table_name);
1593-
int devlink_dpipe_headers_register(struct devlink *devlink,
1593+
void devlink_dpipe_headers_register(struct devlink *devlink,
15941594
struct devlink_dpipe_headers *dpipe_headers);
15951595
void devlink_dpipe_headers_unregister(struct devlink *devlink);
15961596
bool devlink_dpipe_table_counter_enabled(struct devlink *devlink,

net/core/devlink.c

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1700,9 +1700,9 @@ static int devlink_nl_cmd_port_unsplit_doit(struct sk_buff *skb,
17001700
return devlink->ops->port_unsplit(devlink, devlink_port, info->extack);
17011701
}
17021702

1703-
static int devlink_port_new_notifiy(struct devlink *devlink,
1704-
unsigned int port_index,
1705-
struct genl_info *info)
1703+
static int devlink_port_new_notify(struct devlink *devlink,
1704+
unsigned int port_index,
1705+
struct genl_info *info)
17061706
{
17071707
struct devlink_port *devlink_port;
17081708
struct sk_buff *msg;
@@ -1724,8 +1724,7 @@ static int devlink_port_new_notifiy(struct devlink *devlink,
17241724
if (err)
17251725
goto out;
17261726

1727-
err = genlmsg_reply(msg, info);
1728-
return err;
1727+
return genlmsg_reply(msg, info);
17291728

17301729
out:
17311730
nlmsg_free(msg);
@@ -1775,7 +1774,7 @@ static int devlink_nl_cmd_port_new_doit(struct sk_buff *skb,
17751774
if (err)
17761775
return err;
17771776

1778-
err = devlink_port_new_notifiy(devlink, new_port_index, info);
1777+
err = devlink_port_new_notify(devlink, new_port_index, info);
17791778
if (err && err != -ENODEV) {
17801779
/* Fail to send the response; destroy newly created port. */
17811780
devlink->ops->port_del(devlink, new_port_index, extack);
@@ -10425,13 +10424,12 @@ EXPORT_SYMBOL_GPL(devlink_sb_unregister);
1042510424
*
1042610425
* Register the headers supported by hardware.
1042710426
*/
10428-
int devlink_dpipe_headers_register(struct devlink *devlink,
10429-
struct devlink_dpipe_headers *dpipe_headers)
10427+
void devlink_dpipe_headers_register(struct devlink *devlink,
10428+
struct devlink_dpipe_headers *dpipe_headers)
1043010429
{
1043110430
devl_lock(devlink);
1043210431
devlink->dpipe_headers = dpipe_headers;
1043310432
devl_unlock(devlink);
10434-
return 0;
1043510433
}
1043610434
EXPORT_SYMBOL_GPL(devlink_dpipe_headers_register);
1043710435

0 commit comments

Comments
 (0)