Skip to content

Commit 6e80ac5

Browse files
bwhacksdavem330
authored andcommitted
ipv6: xfrm: Handle errors reported by xfrm6_find_1stfragopt()
xfrm6_find_1stfragopt() may now return an error code and we must not treat it as a length. Fixes: 2423496 ("ipv6: Prevent overrun when parsing v6 header options") Signed-off-by: Ben Hutchings <[email protected]> Acked-by: Craig Gallek <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 13fb6c2 commit 6e80ac5

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

net/ipv6/xfrm6_mode_ro.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,8 @@ static int xfrm6_ro_output(struct xfrm_state *x, struct sk_buff *skb)
4747
iph = ipv6_hdr(skb);
4848

4949
hdr_len = x->type->hdr_offset(x, skb, &prevhdr);
50+
if (hdr_len < 0)
51+
return hdr_len;
5052
skb_set_mac_header(skb, (prevhdr - x->props.header_len) - skb->data);
5153
skb_set_network_header(skb, -x->props.header_len);
5254
skb->transport_header = skb->network_header + hdr_len;

net/ipv6/xfrm6_mode_transport.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,8 @@ static int xfrm6_transport_output(struct xfrm_state *x, struct sk_buff *skb)
3030
skb_set_inner_transport_header(skb, skb_transport_offset(skb));
3131

3232
hdr_len = x->type->hdr_offset(x, skb, &prevhdr);
33+
if (hdr_len < 0)
34+
return hdr_len;
3335
skb_set_mac_header(skb, (prevhdr - x->props.header_len) - skb->data);
3436
skb_set_network_header(skb, -x->props.header_len);
3537
skb->transport_header = skb->network_header + hdr_len;

0 commit comments

Comments
 (0)