Skip to content

Commit 6e8fd6e

Browse files
WuHao270gregkh
authored andcommitted
fpga: dfl: add dfl_fpga_port_ops support.
In some cases, other DFL driver modules may need to access some port operations, e.g. disable / enable port for partial reconfiguration in FME module. In order to avoid dependency between port and FME modules, this patch introduces the dfl_fpga_port_ops support in DFL framework. A global dfl_fpga_port_ops list is added in the DFL framework, and it allows other DFL modules to use these port operations registered to this list, even in virtualization case, the port platform device is turned into VF / guest VM and hidden in host, the registered port_ops is still usable. It resolves the dependency issues between modules, but once get port ops API returns a valid port ops, that means related port driver module has been module_get to prevent from unexpected unload, and put port ops API must be invoked after use. These APIs introduced by this patch is listed below: * dfl_fpga_port_ops_add add one port ops to the global list. * dfl_fpga_port_ops_del del one port ops from the global list. * dfl_fpga_port_ops_get / dfl_fpga_port_ops_put get/put the port ops before/after use. Signed-off-by: Wu Hao <[email protected]> Acked-by: Alan Tull <[email protected]> Signed-off-by: Greg Kroah-Hartman <[email protected]>
1 parent 5b57d02 commit 6e8fd6e

File tree

2 files changed

+100
-0
lines changed

2 files changed

+100
-0
lines changed

drivers/fpga/dfl.c

Lines changed: 79 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -136,6 +136,85 @@ static enum dfl_id_type dfh_id_to_type(u32 id)
136136
return DFL_ID_MAX;
137137
}
138138

139+
/*
140+
* introduce a global port_ops list, it allows port drivers to register ops
141+
* in such list, then other feature devices (e.g. FME), could use the port
142+
* functions even related port platform device is hidden. Below is one example,
143+
* in virtualization case of PCIe-based FPGA DFL device, when SRIOV is
144+
* enabled, port (and it's AFU) is turned into VF and port platform device
145+
* is hidden from system but it's still required to access port to finish FPGA
146+
* reconfiguration function in FME.
147+
*/
148+
149+
static DEFINE_MUTEX(dfl_port_ops_mutex);
150+
static LIST_HEAD(dfl_port_ops_list);
151+
152+
/**
153+
* dfl_fpga_port_ops_get - get matched port ops from the global list
154+
* @pdev: platform device to match with associated port ops.
155+
* Return: matched port ops on success, NULL otherwise.
156+
*
157+
* Please note that must dfl_fpga_port_ops_put after use the port_ops.
158+
*/
159+
struct dfl_fpga_port_ops *dfl_fpga_port_ops_get(struct platform_device *pdev)
160+
{
161+
struct dfl_fpga_port_ops *ops = NULL;
162+
163+
mutex_lock(&dfl_port_ops_mutex);
164+
if (list_empty(&dfl_port_ops_list))
165+
goto done;
166+
167+
list_for_each_entry(ops, &dfl_port_ops_list, node) {
168+
/* match port_ops using the name of platform device */
169+
if (!strcmp(pdev->name, ops->name)) {
170+
if (!try_module_get(ops->owner))
171+
ops = NULL;
172+
goto done;
173+
}
174+
}
175+
176+
ops = NULL;
177+
done:
178+
mutex_unlock(&dfl_port_ops_mutex);
179+
return ops;
180+
}
181+
EXPORT_SYMBOL_GPL(dfl_fpga_port_ops_get);
182+
183+
/**
184+
* dfl_fpga_port_ops_put - put port ops
185+
* @ops: port ops.
186+
*/
187+
void dfl_fpga_port_ops_put(struct dfl_fpga_port_ops *ops)
188+
{
189+
if (ops && ops->owner)
190+
module_put(ops->owner);
191+
}
192+
EXPORT_SYMBOL_GPL(dfl_fpga_port_ops_put);
193+
194+
/**
195+
* dfl_fpga_port_ops_add - add port_ops to global list
196+
* @ops: port ops to add.
197+
*/
198+
void dfl_fpga_port_ops_add(struct dfl_fpga_port_ops *ops)
199+
{
200+
mutex_lock(&dfl_port_ops_mutex);
201+
list_add_tail(&ops->node, &dfl_port_ops_list);
202+
mutex_unlock(&dfl_port_ops_mutex);
203+
}
204+
EXPORT_SYMBOL_GPL(dfl_fpga_port_ops_add);
205+
206+
/**
207+
* dfl_fpga_port_ops_del - remove port_ops from global list
208+
* @ops: port ops to del.
209+
*/
210+
void dfl_fpga_port_ops_del(struct dfl_fpga_port_ops *ops)
211+
{
212+
mutex_lock(&dfl_port_ops_mutex);
213+
list_del(&ops->node);
214+
mutex_unlock(&dfl_port_ops_mutex);
215+
}
216+
EXPORT_SYMBOL_GPL(dfl_fpga_port_ops_del);
217+
139218
/**
140219
* dfl_fpga_dev_feature_uinit - uinit for sub features of dfl feature device
141220
* @pdev: feature device.

drivers/fpga/dfl.h

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,27 @@
130130
/* Latency tolerance reporting. '1' >= 40us, '0' < 40us.*/
131131
#define PORT_CTRL_LATENCY BIT_ULL(2)
132132
#define PORT_CTRL_SFTRST_ACK BIT_ULL(4) /* HW ack for reset */
133+
/**
134+
* struct dfl_fpga_port_ops - port ops
135+
*
136+
* @name: name of this port ops, to match with port platform device.
137+
* @owner: pointer to the module which owns this port ops.
138+
* @node: node to link port ops to global list.
139+
* @get_id: get port id from hardware.
140+
* @enable_set: enable/disable the port.
141+
*/
142+
struct dfl_fpga_port_ops {
143+
const char *name;
144+
struct module *owner;
145+
struct list_head node;
146+
int (*get_id)(struct platform_device *pdev);
147+
int (*enable_set)(struct platform_device *pdev, bool enable);
148+
};
149+
150+
void dfl_fpga_port_ops_add(struct dfl_fpga_port_ops *ops);
151+
void dfl_fpga_port_ops_del(struct dfl_fpga_port_ops *ops);
152+
struct dfl_fpga_port_ops *dfl_fpga_port_ops_get(struct platform_device *pdev);
153+
void dfl_fpga_port_ops_put(struct dfl_fpga_port_ops *ops);
133154

134155
/**
135156
* struct dfl_feature_driver - sub feature's driver

0 commit comments

Comments
 (0)