Skip to content

Commit 6edf074

Browse files
ryderlee1110nbd168
authored andcommitted
mt76: add unlikely() for dma_mapping_error() check
In the tx/rx fastpath, the funciton dma_map_single() rarely fails. This adds unlikely() optimization to this error check conditional. Signed-off-by: Ryder Lee <[email protected]> Signed-off-by: Felix Fietkau <[email protected]>
1 parent 04b8e65 commit 6edf074

File tree

1 file changed

+4
-4
lines changed
  • drivers/net/wireless/mediatek/mt76

1 file changed

+4
-4
lines changed

drivers/net/wireless/mediatek/mt76/dma.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ mt76_dma_tx_queue_skb_raw(struct mt76_dev *dev, enum mt76_txq_id qid,
272272

273273
addr = dma_map_single(dev->dev, skb->data, skb->len,
274274
DMA_TO_DEVICE);
275-
if (dma_mapping_error(dev->dev, addr))
275+
if (unlikely(dma_mapping_error(dev->dev, addr)))
276276
return -ENOMEM;
277277

278278
buf.addr = addr;
@@ -315,7 +315,7 @@ mt76_dma_tx_queue_skb(struct mt76_dev *dev, enum mt76_txq_id qid,
315315

316316
len = skb_headlen(skb);
317317
addr = dma_map_single(dev->dev, skb->data, len, DMA_TO_DEVICE);
318-
if (dma_mapping_error(dev->dev, addr))
318+
if (unlikely(dma_mapping_error(dev->dev, addr)))
319319
goto free;
320320

321321
tx_info.buf[n].addr = t->dma_addr;
@@ -329,7 +329,7 @@ mt76_dma_tx_queue_skb(struct mt76_dev *dev, enum mt76_txq_id qid,
329329

330330
addr = dma_map_single(dev->dev, iter->data, iter->len,
331331
DMA_TO_DEVICE);
332-
if (dma_mapping_error(dev->dev, addr))
332+
if (unlikely(dma_mapping_error(dev->dev, addr)))
333333
goto unmap;
334334

335335
tx_info.buf[n].addr = addr;
@@ -386,7 +386,7 @@ mt76_dma_rx_fill(struct mt76_dev *dev, struct mt76_queue *q)
386386
break;
387387

388388
addr = dma_map_single(dev->dev, buf, len, DMA_FROM_DEVICE);
389-
if (dma_mapping_error(dev->dev, addr)) {
389+
if (unlikely(dma_mapping_error(dev->dev, addr))) {
390390
skb_free_frag(buf);
391391
break;
392392
}

0 commit comments

Comments
 (0)