Skip to content

Commit 6edf101

Browse files
Elad Razdavem330
authored andcommitted
devlink: Prevent port_type_set() callback when it's not needed
When a port_type_set() is been called and the new port type set is the same as the old one, just return success. Signed-off-by: Elad Raz <[email protected]> Signed-off-by: Jiri Pirko <[email protected]> Signed-off-by: David S. Miller <[email protected]>
1 parent 89ab88b commit 6edf101

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

net/core/devlink.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -608,6 +608,8 @@ static int devlink_port_type_set(struct devlink *devlink,
608608
if (devlink->ops && devlink->ops->port_type_set) {
609609
if (port_type == DEVLINK_PORT_TYPE_NOTSET)
610610
return -EINVAL;
611+
if (port_type == devlink_port->type)
612+
return 0;
611613
err = devlink->ops->port_type_set(devlink_port, port_type);
612614
if (err)
613615
return err;

0 commit comments

Comments
 (0)