Skip to content

Commit 6efa094

Browse files
GustavoARSilvamchehab
authored andcommitted
media: sir_ir: remove unnecessary static in sir_interrupt()
Remove unnecessary static on local variable delt. Such variable is initialized before being used, on every execution path throughout the function. The static has no benefit and, removing it reduces the code size. This issue was detected using Coccinelle and the following semantic patch: @bad exists@ position p; identifier x; type T; @@ static T x@p; ... x = <+...x...+> @@ identifier x; expression e; type T; position p != bad.p; @@ -static T x@p; ... when != x when strict ?x = e; In the following log you can see the difference in the code size. Also, there is a significant difference in the bss segment. This log is the output of the size command, before and after the code change: before: text data bss dec hex filename 5009 3456 576 9041 2351 drivers/media/rc/sir_ir.o after: text data bss dec hex filename 4988 3400 512 8900 22c4 drivers/media/rc/sir_ir.o Signed-off-by: Gustavo A. R. Silva <[email protected]> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
1 parent b9e1486 commit 6efa094

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/media/rc/sir_ir.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ static irqreturn_t sir_interrupt(int irq, void *dev_id)
155155
{
156156
unsigned char data;
157157
ktime_t curr_time;
158-
static unsigned long delt;
158+
unsigned long delt;
159159
unsigned long deltintr;
160160
unsigned long flags;
161161
int counter = 0;

0 commit comments

Comments
 (0)