Skip to content

Commit 6f0b958

Browse files
Srinivas-Kandagatlaandersson
authored andcommitted
rpmsg: glink: Fix various kerneldoc warnings.
Fix below kerneldoc warnings while building with W=1 qcom_glink_native.c:53: warning: Function parameter or member 'data' not described in 'glink_defer_cmd' qcom_glink_native.c:75: warning: Function parameter or member 'data' not described in 'glink_core_rx_intent' qcom_glink_native.c:75: warning: Function parameter or member 'id' not described in 'glink_core_rx_intent' qcom_glink_native.c:75: warning: Function parameter or member 'size' not described in 'glink_core_rx_intent' qcom_glink_native.c:75: warning: Function parameter or member 'reuse' not described in 'glink_core_rx_intent' qcom_glink_native.c:75: warning: Function parameter or member 'in_use' not described in 'glink_core_rx_intent' qcom_glink_native.c:75: warning: Function parameter or member 'offset' not described in 'glink_core_rx_intent' qcom_glink_native.c:75: warning: Function parameter or member 'node' not described in 'glink_core_rx_intent' qcom_glink_native.c:116: warning: Function parameter or member 'features' not described in 'qcom_glink' qcom_glink_native.c:116: warning: Function parameter or member 'intentless' not described in 'qcom_glink' qcom_glink_native.c:524: warning: Function parameter or member 'version' not described in 'qcom_glink_receive_version' qcom_glink_native.c:524: warning: Function parameter or member 'features' not described in 'qcom_glink_receive_version' qcom_glink_native.c:524: warning: Excess function parameter 'r_version' description in 'qcom_glink_receive_version' qcom_glink_native.c:524: warning: Excess function parameter 'r_features' description in 'qcom_glink_receive_version' qcom_glink_native.c:551: warning: Function parameter or member 'version' not described in 'qcom_glink_receive_version_ack' qcom_glink_native.c:551: warning: Function parameter or member 'features' not described in 'qcom_glink_receive_version_ack' qcom_glink_native.c:551: warning: Excess function parameter 'r_version' description in 'qcom_glink_receive_version_ack' qcom_glink_native.c:551: warning: Excess function parameter 'r_features' description in 'qcom_glink_receive_version_ack' qcom_glink_native.c:570: warning: bad line: wire format and transmit qcom_glink_native.c:604: warning: Function parameter or member 'intent' not described in 'qcom_glink_advertise_intent' qcom_glink_native.c:604: warning: Excess function parameter 'size' description in 'qcom_glink_advertise_intent' qcom_glink_native.c:710: warning: Function parameter or member 'glink' not described in 'qcom_glink_handle_intent_req' qcom_glink_native.c:710: warning: Function parameter or member 'cid' not described in 'qcom_glink_handle_intent_req' qcom_glink_native.c:710: warning: Function parameter or member 'size' not described in 'qcom_glink_handle_intent_req' Signed-off-by: Srinivas Kandagatla <[email protected]> Signed-off-by: Bjorn Andersson <[email protected]>
1 parent 427613e commit 6f0b958

File tree

1 file changed

+19
-16
lines changed

1 file changed

+19
-16
lines changed

drivers/rpmsg/qcom_glink_native.c

Lines changed: 19 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ struct glink_msg {
4040
* struct glink_defer_cmd - deferred incoming control message
4141
* @node: list node
4242
* @msg: message header
43-
* data: payload of the message
43+
* @data: payload of the message
4444
*
4545
* Copy of a received control message, to be added to @rx_queue and processed
4646
* by @rx_work of @qcom_glink.
@@ -56,12 +56,13 @@ struct glink_defer_cmd {
5656
* struct glink_core_rx_intent - RX intent
5757
* RX intent
5858
*
59-
* data: pointer to the data (may be NULL for zero-copy)
60-
* id: remote or local intent ID
61-
* size: size of the original intent (do not modify)
62-
* reuse: To mark if the intent can be reused after first use
63-
* in_use: To mark if intent is already in use for the channel
64-
* offset: next write offset (initially 0)
59+
* @data: pointer to the data (may be NULL for zero-copy)
60+
* @id: remote or local intent ID
61+
* @size: size of the original intent (do not modify)
62+
* @reuse: To mark if the intent can be reused after first use
63+
* @in_use: To mark if intent is already in use for the channel
64+
* @offset: next write offset (initially 0)
65+
* @node: list node
6566
*/
6667
struct glink_core_rx_intent {
6768
void *data;
@@ -89,6 +90,8 @@ struct glink_core_rx_intent {
8990
* @idr_lock: synchronizes @lcids and @rcids modifications
9091
* @lcids: idr of all channels with a known local channel id
9192
* @rcids: idr of all channels with a known remote channel id
93+
* @features: remote features
94+
* @intentless: flag to indicate that there is no intent
9295
*/
9396
struct qcom_glink {
9497
struct device *dev;
@@ -512,8 +515,8 @@ static void qcom_glink_rx_done(struct qcom_glink *glink,
512515
* qcom_glink_receive_version() - receive version/features from remote system
513516
*
514517
* @glink: pointer to transport interface
515-
* @r_version: remote version
516-
* @r_features: remote features
518+
* @version: remote version
519+
* @features: remote features
517520
*
518521
* This function is called in response to a remote-initiated version/feature
519522
* negotiation sequence.
@@ -538,8 +541,8 @@ static void qcom_glink_receive_version(struct qcom_glink *glink,
538541
* qcom_glink_receive_version_ack() - receive negotiation ack from remote system
539542
*
540543
* @glink: pointer to transport interface
541-
* @r_version: remote version response
542-
* @r_features: remote features response
544+
* @version: remote version response
545+
* @features: remote features response
543546
*
544547
* This function is called in response to a local-initiated version/feature
545548
* negotiation sequence and is the counter-offer from the remote side based
@@ -567,7 +570,7 @@ static void qcom_glink_receive_version_ack(struct qcom_glink *glink,
567570

568571
/**
569572
* qcom_glink_send_intent_req_ack() - convert an rx intent request ack cmd to
570-
wire format and transmit
573+
* wire format and transmit
571574
* @glink: The transport to transmit on.
572575
* @channel: The glink channel
573576
* @granted: The request response to encode.
@@ -594,7 +597,7 @@ static int qcom_glink_send_intent_req_ack(struct qcom_glink *glink,
594597
* transmit
595598
* @glink: The transport to transmit on.
596599
* @channel: The local channel
597-
* @size: The intent to pass on to remote.
600+
* @intent: The intent to pass on to remote.
598601
*
599602
* Return: 0 on success or standard Linux error code.
600603
*/
@@ -698,9 +701,9 @@ static void qcom_glink_handle_rx_done(struct qcom_glink *glink,
698701
/**
699702
* qcom_glink_handle_intent_req() - Receive a request for rx_intent
700703
* from remote side
701-
* if_ptr: Pointer to the transport interface
702-
* rcid: Remote channel ID
703-
* size: size of the intent
704+
* @glink: Pointer to the transport interface
705+
* @cid: Remote channel ID
706+
* @size: size of the intent
704707
*
705708
* The function searches for the local channel to which the request for
706709
* rx_intent has arrived and allocates and notifies the remote back

0 commit comments

Comments
 (0)